Attention is currently required from: Martin L Roth, Angel Pons.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68992 )
Change subject: device/dram: Add kconfig options for memory types
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Update to self: And how do you deal with the build problems? Don't bother for now.
The mainboard can't unselect them currently, but we could fix that if it was really desirable.
We could either change from selects to setting defaults, or move the selects into a separate Kconfig option that could be defaulted to off and overridden by a mainboard.
If you think that's worthwhile, I can go ahead and add it. This was an initial implementation, and I don't mind updating it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68992
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I07c98a702e0d67c5ad7bd9b8a4ff24c9288ab569
Gerrit-Change-Number: 68992
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 02 Nov 2022 18:51:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment