Change in coreboot[master]: AGESA: Restrict use of -fno-zero-initialized-in-bss

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Kyösti Mälkki (Code Review)

15 Aug 2019 15 Aug '19

4:14 p.m.

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34885 )

Change subject: AGESA: Restrict use of -fno-zero-initialized-in-bss ......................................................................

AGESA: Restrict use of -fno-zero-initialized-in-bss

Only apply the flag for libagesa -class.

Change-Id: Ide46214d62b2b16e5e1deaa0796be784ed813095 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/vendorcode/amd/agesa/Makefile.inc 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/34885/1

diff --git a/src/vendorcode/amd/agesa/Makefile.inc b/src/vendorcode/amd/agesa/Makefile.inc index d672cf4..da59004 100644 --- a/src/vendorcode/amd/agesa/Makefile.inc +++ b/src/vendorcode/amd/agesa/Makefile.inc @@ -10,9 +10,10 @@ classes-y += libagesa libagesa-y = libagesa-generic-ccopts += -D__LIBAGESA__ +libagesa-generic-ccopts += -fno-zero-initialized-in-bss libagesa-generic-ccopts += $(AGESA_INC) $(AGESA_AUTOINCLUDES)

-AGESA_CFLAGS := -march=k8-sse3 -mtune=k8-sse3 -fno-zero-initialized-in-bss -fno-strict-aliasing +AGESA_CFLAGS := -march=k8-sse3 -mtune=k8-sse3 -fno-strict-aliasing

CFLAGS_x86_32 += $(AGESA_CFLAGS) CFLAGS_x86_64 += $(AGESA_CFLAGS)

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

Kyösti Mälkki (Code Review)

15 Aug 15 Aug

4:14 p.m.

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34885 )

Change subject: AGESA: Restrict use of -fno-zero-initialized-in-bss ......................................................................

Patch Set 1: Code-Review-2

not tested

-- To view, visit https://review.coreboot.org/c/coreboot/+/34885 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide46214d62b2b16e5e1deaa0796be784ed813095 Gerrit-Change-Number: 34885 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Thu, 15 Aug 2019 14:14:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Aaron Durbin (Code Review)

4:25 p.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34885 )

Change subject: AGESA: Restrict use of -fno-zero-initialized-in-bss ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/34885 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide46214d62b2b16e5e1deaa0796be784ed813095 Gerrit-Change-Number: 34885 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Thu, 15 Aug 2019 14:25:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Marshall Dawson (Code Review)

20 Aug 20 Aug

4:31 a.m.

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34885 )

Change subject: AGESA: Restrict use of -fno-zero-initialized-in-bss ......................................................................

Patch Set 5: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/34885 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide46214d62b2b16e5e1deaa0796be784ed813095 Gerrit-Change-Number: 34885 Gerrit-PatchSet: 5 Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 20 Aug 2019 02:31:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Marshall Dawson (Code Review)

7:33 p.m.

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34885 )

Change subject: AGESA: Restrict use of -fno-zero-initialized-in-bss ......................................................................

Patch Set 6: -Code-Review

Missed your -2 yesterday so removing my +2

-- To view, visit https://review.coreboot.org/c/coreboot/+/34885 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide46214d62b2b16e5e1deaa0796be784ed813095 Gerrit-Change-Number: 34885 Gerrit-PatchSet: 6 Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 20 Aug 2019 17:33:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Kyösti Mälkki (Code Review)

22 Aug 22 Aug

7:20 p.m.

Kyösti Mälkki has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/34885 )

Change subject: AGESA: Restrict use of -fno-zero-initialized-in-bss ......................................................................

Removed Code-Review-2 by Kyösti Mälkki kyosti.malkki@gmail.com

-- To view, visit https://review.coreboot.org/c/coreboot/+/34885 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide46214d62b2b16e5e1deaa0796be784ed813095 Gerrit-Change-Number: 34885 Gerrit-PatchSet: 10 Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: deleteVote

Kyösti Mälkki (Code Review)

7:21 p.m.

Kyösti Mälkki has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34885 )

Change subject: AGESA: Restrict use of -fno-zero-initialized-in-bss ......................................................................

AGESA: Restrict use of -fno-zero-initialized-in-bss

Only apply the flag for libagesa -class.

Change-Id: Ide46214d62b2b16e5e1deaa0796be784ed813095 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34885 Reviewed-by: Aaron Durbin adurbin@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/vendorcode/amd/agesa/Makefile.inc 1 file changed, 2 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved

-AGESA_CFLAGS := -march=k8-sse3 -mtune=k8-sse3 -fno-zero-initialized-in-bss -fno-strict-aliasing +AGESA_CFLAGS := -march=k8-sse3 -mtune=k8-sse3 -fno-strict-aliasing

CFLAGS_x86_32 += $(AGESA_CFLAGS) CFLAGS_x86_64 += $(AGESA_CFLAGS)

-- To view, visit https://review.coreboot.org/c/coreboot/+/34885 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide46214d62b2b16e5e1deaa0796be784ed813095 Gerrit-Change-Number: 34885 Gerrit-PatchSet: 11 Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

2080

days inactive

2087

days old

coreboot-gerrit@coreboot.org

6 comments

3 participants

tags (0)

participants (3)

Aaron Durbin (Code Review)
Kyösti Mälkki (Code Review)
Marshall Dawson (Code Review)