Change in coreboot[master]: mb/google/dedede/var/sasuke: Add memory part and generate DRAM ID
Hello SH Kim,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/48451
to review the following change.
Change subject: mb/google/dedede/var/sasuke: Add memory part and generate DRAM ID ......................................................................
mb/google/dedede/var/sasuke: Add memory part and generate DRAM ID
This change adds memory part used by variant sasuke to mem_part_used.txt and generates DRAM ID allocated to the part.
BUG=b:172104731
Change-Id: Ie8d66261cb5b4493afb1c677839f807bca994af5 Signed-off-by: Seunghwan Kim sh_.kim@samsung.corp-partner.google.com --- M src/mainboard/google/dedede/variants/sasuke/memory/Makefile.inc M src/mainboard/google/dedede/variants/sasuke/memory/dram_id.generated.txt M src/mainboard/google/dedede/variants/sasuke/memory/mem_parts_used.txt 3 files changed, 4 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/48451/1
diff --git a/src/mainboard/google/dedede/variants/sasuke/memory/Makefile.inc b/src/mainboard/google/dedede/variants/sasuke/memory/Makefile.inc index b0ca222..1d39fbc 100644 --- a/src/mainboard/google/dedede/variants/sasuke/memory/Makefile.inc +++ b/src/mainboard/google/dedede/variants/sasuke/memory/Makefile.inc @@ -1,5 +1,5 @@ ## SPDX-License-Identifier: GPL-2.0-or-later ## This is an auto-generated file. Do not edit!! -## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
-SPD_SOURCES = placeholder.spd.hex +SPD_SOURCES = +SPD_SOURCES += lp4x-spd-1.hex # ID = 0(0b0000) Parts = K4U6E3S4AA-MGCR diff --git a/src/mainboard/google/dedede/variants/sasuke/memory/dram_id.generated.txt b/src/mainboard/google/dedede/variants/sasuke/memory/dram_id.generated.txt index fa24790..da0441c 100644 --- a/src/mainboard/google/dedede/variants/sasuke/memory/dram_id.generated.txt +++ b/src/mainboard/google/dedede/variants/sasuke/memory/dram_id.generated.txt @@ -1 +1,2 @@ DRAM Part Name ID to assign +K4U6E3S4AA-MGCR 0 (0000) diff --git a/src/mainboard/google/dedede/variants/sasuke/memory/mem_parts_used.txt b/src/mainboard/google/dedede/variants/sasuke/memory/mem_parts_used.txt index 59381dc..e916160 100644 --- a/src/mainboard/google/dedede/variants/sasuke/memory/mem_parts_used.txt +++ b/src/mainboard/google/dedede/variants/sasuke/memory/mem_parts_used.txt @@ -1,6 +1 @@ -# This is a CSV file containing a list of memory parts used by this variant. -# Generate an updated Makefile.inc and dram_id.generated.txt by running the -# gen_part_id tool from util/spd_tools/lp4x -# See util/spd_tools/lp4x/README.md for more details and instructions. - -# Part Name +K4U6E3S4AA-MGCR
Raymond Chung has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48451 )
Change subject: mb/google/dedede/var/sasuke: Add memory part and generate DRAM ID ......................................................................
Patch Set 1: Code-Review+1
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48451 )
Change subject: mb/google/dedede/var/sasuke: Add memory part and generate DRAM ID ......................................................................
Patch Set 1: Code-Review+1
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48451 )
Change subject: mb/google/dedede/var/sasuke: Add memory part and generate DRAM ID ......................................................................
Patch Set 1: Code-Review+2
Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48451 )
Change subject: mb/google/dedede/var/sasuke: Add memory part and generate DRAM ID ......................................................................
mb/google/dedede/var/sasuke: Add memory part and generate DRAM ID
This change adds memory part used by variant sasuke to mem_part_used.txt and generates DRAM ID allocated to the part.
BUG=b:172104731
Change-Id: Ie8d66261cb5b4493afb1c677839f807bca994af5 Signed-off-by: Seunghwan Kim sh_.kim@samsung.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/48451 Reviewed-by: Raymond Chung raymondchung@ami.corp-partner.google.com Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/dedede/variants/sasuke/memory/Makefile.inc M src/mainboard/google/dedede/variants/sasuke/memory/dram_id.generated.txt M src/mainboard/google/dedede/variants/sasuke/memory/mem_parts_used.txt 3 files changed, 4 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved Raymond Chung: Looks good to me, but someone else must approve Paul Fagerburg: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/dedede/variants/sasuke/memory/Makefile.inc b/src/mainboard/google/dedede/variants/sasuke/memory/Makefile.inc index b0ca222..1d39fbc 100644 --- a/src/mainboard/google/dedede/variants/sasuke/memory/Makefile.inc +++ b/src/mainboard/google/dedede/variants/sasuke/memory/Makefile.inc @@ -1,5 +1,5 @@ ## SPDX-License-Identifier: GPL-2.0-or-later ## This is an auto-generated file. Do not edit!! -## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
-SPD_SOURCES = placeholder.spd.hex +SPD_SOURCES = +SPD_SOURCES += lp4x-spd-1.hex # ID = 0(0b0000) Parts = K4U6E3S4AA-MGCR diff --git a/src/mainboard/google/dedede/variants/sasuke/memory/dram_id.generated.txt b/src/mainboard/google/dedede/variants/sasuke/memory/dram_id.generated.txt index fa24790..da0441c 100644 --- a/src/mainboard/google/dedede/variants/sasuke/memory/dram_id.generated.txt +++ b/src/mainboard/google/dedede/variants/sasuke/memory/dram_id.generated.txt @@ -1 +1,2 @@ DRAM Part Name ID to assign +K4U6E3S4AA-MGCR 0 (0000) diff --git a/src/mainboard/google/dedede/variants/sasuke/memory/mem_parts_used.txt b/src/mainboard/google/dedede/variants/sasuke/memory/mem_parts_used.txt index 59381dc..e916160 100644 --- a/src/mainboard/google/dedede/variants/sasuke/memory/mem_parts_used.txt +++ b/src/mainboard/google/dedede/variants/sasuke/memory/mem_parts_used.txt @@ -1,6 +1 @@ -# This is a CSV file containing a list of memory parts used by this variant. -# Generate an updated Makefile.inc and dram_id.generated.txt by running the -# gen_part_id tool from util/spd_tools/lp4x -# See util/spd_tools/lp4x/README.md for more details and instructions. - -# Part Name +K4U6E3S4AA-MGCR
shkim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48451 )
Change subject: mb/google/dedede/var/sasuke: Add memory part and generate DRAM ID ......................................................................
Patch Set 3:
Can we merge this change?
shkim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48451 )
Change subject: mb/google/dedede/var/sasuke: Add memory part and generate DRAM ID ......................................................................
Patch Set 3:
Patch Set 3:
Can we merge this change?
Sorry. The comment was not for this change.
-
Hung-Te Lin (Code Review) -
Karthik Ramasubramanian (Code Review)
-
Paul Fagerburg (Code Review)
-
Raymond Chung (Code Review)
-
shkim (Code Review)