Attention is currently required from: Jason Glenesk, Matt DeVillier, Martin Roth, Tim Van Patten, Fred Reitberger, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67181 )
Change subject: soc/amd: Remove unsupported DPTC tablet mode settings
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS5:
Currently, no tablet mode DPTC values exist for these SOCs in the device tree, so the feature can't be enabled for anything anyway. This removes the possibility of enabling a broken feature.
Well you would set the values and set `dptc_enable = true`. So I wouldn't say it's enabling a broken feature, it just needs to be configured.
If this is the case, maybe tablet mode shouldn't be an SOC feature and should be moved into the mainboards for boards that do support it?
Well here's the dirty little secret, the `.asl` is looking at Chrome EC specific registers to determine the states. So it really is a Google specific feature right now. We just don't have a good spot for chromeos/amd code that is shared between SoCs.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67181
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ide96f255b69670d1b4c37ca2f94cc3504a958b57
Gerrit-Change-Number: 67181
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 02 Sep 2022 17:46:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Gerrit-MessageType: comment