Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38838 )
Change subject: cpu: Add initial xeonsp support broilerplate
......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38838/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38838/2//COMMIT_MSG@7
PS2, Line 7: broilerplate
boilerplate?
Very likely.
https://review.coreboot.org/c/coreboot/+/38838/2//COMMIT_MSG@9
PS2, Line 9: broilerplate
same here
https://review.coreboot.org/c/coreboot/+/38838/2//COMMIT_MSG@10
PS2, Line 10: xeonsp
Xeon SP
Is it Xeon Single Processor or Xeon Scalable Platform? If the latter, I would probably call it "Xeon Scalable", and use "xeon_scalable"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38838
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I24346b8a5c30342419db23b5f1adf27d4d0ebc5f
Gerrit-Change-Number: 38838
Gerrit-PatchSet: 2
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 17 Feb 2020 12:23:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment