Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42873 )
Change subject: mb/amd/padmelon: Drop SCI configuration for GPIO_137 ......................................................................
mb/amd/padmelon: Drop SCI configuration for GPIO_137
GPIO_137 does not have any gevent associated with it. This change drops the configuration of GPIO_137 as SCI for padmelon.
Change-Id: I0579d05bda4523bbb5e3441d2a3b6e2b33b05cfc Signed-off-by: Furquan Shaikh furquan@google.com --- M src/mainboard/amd/padmelon/gpio.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/42873/1
diff --git a/src/mainboard/amd/padmelon/gpio.c b/src/mainboard/amd/padmelon/gpio.c index 2918647..7897d7b 100644 --- a/src/mainboard/amd/padmelon/gpio.c +++ b/src/mainboard/amd/padmelon/gpio.c @@ -26,7 +26,6 @@ /* DEVSLP1 */ PAD_NF(GPIO_70, DEVSLP1, PULL_UP), /* WLAND */ - PAD_SCI(GPIO_137, PULL_UP, LEVEL_LOW), PAD_WAKE(GPIO_137, PULL_UP, LEVEL_LOW, S3), #else /* PCIE_WAKE */
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42873 )
Change subject: mb/amd/padmelon: Drop SCI configuration for GPIO_137 ......................................................................
Patch Set 2: Code-Review+1
No schematic or board here.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42873 )
Change subject: mb/amd/padmelon: Drop SCI configuration for GPIO_137 ......................................................................
Patch Set 3: Code-Review+2
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42873 )
Change subject: mb/amd/padmelon: Drop SCI configuration for GPIO_137 ......................................................................
Patch Set 3: Code-Review+2
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42873 )
Change subject: mb/amd/padmelon: Drop SCI configuration for GPIO_137 ......................................................................
mb/amd/padmelon: Drop SCI configuration for GPIO_137
GPIO_137 does not have any gevent associated with it. This change drops the configuration of GPIO_137 as SCI for padmelon.
Change-Id: I0579d05bda4523bbb5e3441d2a3b6e2b33b05cfc Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42873 Reviewed-by: Raul Rangel rrangel@chromium.org Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/amd/padmelon/gpio.c 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, but someone else must approve Aaron Durbin: Looks good to me, approved Raul Rangel: Looks good to me, approved
diff --git a/src/mainboard/amd/padmelon/gpio.c b/src/mainboard/amd/padmelon/gpio.c index 2918647..7897d7b 100644 --- a/src/mainboard/amd/padmelon/gpio.c +++ b/src/mainboard/amd/padmelon/gpio.c @@ -26,7 +26,6 @@ /* DEVSLP1 */ PAD_NF(GPIO_70, DEVSLP1, PULL_UP), /* WLAND */ - PAD_SCI(GPIO_137, PULL_UP, LEVEL_LOW), PAD_WAKE(GPIO_137, PULL_UP, LEVEL_LOW, S3), #else /* PCIE_WAKE */
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42873 )
Change subject: mb/amd/padmelon: Drop SCI configuration for GPIO_137 ......................................................................
Patch Set 5:
Automatic boot test returned (PASS/FAIL/TOTAL): 2/2/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : FAIL : https://lava.9esec.io/r/7707 "QEMU x86 q35/ich9" using payload SeaBIOS : FAIL : https://lava.9esec.io/r/7706 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/7705 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/7704
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Aaron Durbin (Code Review)
-
Furquan Shaikh (Code Review)
-
Kyösti Mälkki (Code Review)
-
Raul Rangel (Code Review)