Julius Werner has posted comments on this change. ( https://review.coreboot.org/19770 )
Change subject: soc/mediatek/mt8173: Move spi driver to use spi_bus_map ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/19770/1/src/soc/mediatek/mt8173/spi.c File src/soc/mediatek/mt8173/spi.c:
Line 333: .bus_end = CONFIG_EC_GOOGLE_CHROMEEC_SPI_BUS,
Yeah, I just tried to keep the changes as minimal as possible from the orig
I'm just suggesting to replace this with a literal 0 for now. That will come out to the same value (for Oak, which is the only board using this right now). This would make more sense if a future board might not want to use an EC and connect something different here instead.
For the other one, it's a bit more debatable I guess since that controller can only be used for flash anyway. The number Oak currently uses there is 9. I guess we could just put that literal here too, and say that 9 is our NOR flash controller number... or we could leave this one as it is since it's very likely that all board will want to use it for boot flash. (I would maybe not change it to #1 since it's possible that a future Mediatek chip with more generic SPI controllers might want to reuse this code, and then we'd want all the generic ones to be contiguous e.g. from 0 to 3.)
-
Julius Werner (Code Review)