Change in coreboot[master]: mb/google/octopus: Enable DRAM_PART_NUM_IN_CBI feature for Dood

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Ren Kuo (Code Review)

18 Dec 2019 18 Dec '19

6:43 a.m.

Ren Kuo has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37808 )

Change subject: mb/google/octopus: Enable DRAM_PART_NUM_IN_CBI feature for Dood ......................................................................

mb/google/octopus: Enable DRAM_PART_NUM_IN_CBI feature for Dood

Enable DRAM_PART_NUM_IN_CBI feature to get DRAM part number from CBI and set DRAM_PART_IN_CBI_BOARD_ID_MIN to 3 for dood EVT

BUG=b:146317464 TEST=build coreboot

Change-Id: Ic7c8fa254eff540f244b1f9c6229c11d07397b26 --- M src/mainboard/google/octopus/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/37808/1

diff --git a/src/mainboard/google/octopus/Kconfig b/src/mainboard/google/octopus/Kconfig index 3139716..414d848 100644 --- a/src/mainboard/google/octopus/Kconfig +++ b/src/mainboard/google/octopus/Kconfig @@ -118,6 +118,7 @@ config DRAM_PART_NUM_NOT_ALWAYS_IN_CBI bool default y if BOARD_GOOGLE_BOBBA + default y if BOARD_GOOGLE_DOOD default y if BOARD_GOOGLE_FLEEX default y if BOARD_GOOGLE_MEEP default y if BOARD_GOOGLE_OCTOPUS @@ -133,5 +134,6 @@ default 3 if BOARD_GOOGLE_BOBBA default 1 if BOARD_GOOGLE_MEEP default 255 if BOARD_GOOGLE_OCTOPUS + default 3 if BOARD_GOOGLE_DOOD

endif # BOARD_GOOGLE_OCTOPUS

Attachments:

attachment.htm (text/html — 2.8 KB)

Show replies by date

Ren Kuo (Code Review)

18 Dec 18 Dec

6:45 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37808

to look at the new patch set (#2).

Change subject: mb/google/octopus: Enable DRAM_PART_NUM_IN_CBI feature for Dood ......................................................................

mb/google/octopus: Enable DRAM_PART_NUM_IN_CBI feature for Dood

Enable DRAM_PART_NUM_IN_CBI feature to get DRAM part number from CBI and set DRAM_PART_IN_CBI_BOARD_ID_MIN to 3 for dood EVT

BUG=b:146317464 TEST=build coreboot

Change-Id: Ic7c8fa254eff540f244b1f9c6229c11d07397b26 Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com --- M src/mainboard/google/octopus/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/37808/2

Ren Kuo (Code Review)

6:48 a.m.

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37808 )

Change subject: mb/google/octopus: Enable DRAM_PART_NUM_IN_CBI feature for Dood ......................................................................

Patch Set 2: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/37808 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7c8fa254eff540f244b1f9c6229c11d07397b26 Gerrit-Change-Number: 37808 Gerrit-PatchSet: 2 Gerrit-Owner: Ren Kuo ren.kuo@quanta.corp-partner.google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Ren Kuo ren.kuo@quanta.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Tim Chen tim-chen@quanta.corp-partner.google.com Gerrit-Comment-Date: Wed, 18 Dec 2019 06:48:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Henry Sun (Code Review)

6:58 a.m.

Henry Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37808 )

Change subject: mb/google/octopus: Enable DRAM_PART_NUM_IN_CBI feature for Dood ......................................................................

Patch Set 2: Code-Review-1

Hi Ren,

Dood should already has it's own firmware variant, in that case, it should have DRAM part number in CBI always. Any reason you'd like to add it in DRAM_PART_NUM_NOT_ALWAYS_IN_CBI section?

-- To view, visit https://review.coreboot.org/c/coreboot/+/37808 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7c8fa254eff540f244b1f9c6229c11d07397b26 Gerrit-Change-Number: 37808 Gerrit-PatchSet: 2 Gerrit-Owner: Ren Kuo ren.kuo@quanta.corp-partner.google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Ren Kuo ren.kuo@quanta.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Tim Chen tim-chen@quanta.corp-partner.google.com Gerrit-Comment-Date: Wed, 18 Dec 2019 06:58:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Ren Kuo (Code Review)

25 Dec 25 Dec

1:59 a.m.

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37808 )

Change subject: mb/google/octopus: Enable DRAM_PART_NUM_IN_CBI feature for Dood ......................................................................

Patch Set 2:

...

Patch Set 2: Code-Review-1

Hi Ren,

Dood should already has it's own firmware variant, in that case, it should have DRAM part number in CBI always. Any reason you'd like to add it in DRAM_PART_NUM_NOT_ALWAYS_IN_CBI section?

the octopus 's board id =255, we need to define the dood as board id =3

-- To view, visit https://review.coreboot.org/c/coreboot/+/37808 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7c8fa254eff540f244b1f9c6229c11d07397b26 Gerrit-Change-Number: 37808 Gerrit-PatchSet: 2 Gerrit-Owner: Ren Kuo ren.kuo@quanta.corp-partner.google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Ren Kuo ren.kuo@quanta.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Tim Chen tim-chen@quanta.corp-partner.google.com Gerrit-Comment-Date: Wed, 25 Dec 2019 01:59:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Henry Sun (Code Review)

2:33 a.m.

Henry Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37808 )

Change subject: mb/google/octopus: Enable DRAM_PART_NUM_IN_CBI feature for Dood ......................................................................

Patch Set 2:

Hi Ren,

Discussed with Marco, this config of DRAM_PART_NUM_IN_CBI feature is added in the middle of octopus projects, and it's only for projects BEFORE adding this config. so any project (variant) created after adding this CONFIG will not need to have it. Dood's board version will not impact on this either.

Thanks!

-- To view, visit https://review.coreboot.org/c/coreboot/+/37808 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7c8fa254eff540f244b1f9c6229c11d07397b26 Gerrit-Change-Number: 37808 Gerrit-PatchSet: 2 Gerrit-Owner: Ren Kuo ren.kuo@quanta.corp-partner.google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: Ren Kuo ren.kuo@quanta.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Tim Chen tim-chen@quanta.corp-partner.google.com Gerrit-Comment-Date: Wed, 25 Dec 2019 02:33:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Ren Kuo (Code Review)

2:40 a.m.

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37808 )

Change subject: mb/google/octopus: Enable DRAM_PART_NUM_IN_CBI feature for Dood ......................................................................

Patch Set 2: -Code-Review

...

Patch Set 2:

Hi Ren,

Discussed with Marco, this config of DRAM_PART_NUM_IN_CBI feature is added in the middle of octopus projects, and it's only for projects BEFORE adding this config. so any project (variant) created after adding this CONFIG will not need to have it. Dood's board version will not impact on this either.

Thanks!

OK. I see !!

-- To view, visit https://review.coreboot.org/c/coreboot/+/37808 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7c8fa254eff540f244b1f9c6229c11d07397b26 Gerrit-Change-Number: 37808 Gerrit-PatchSet: 2 Gerrit-Owner: Ren Kuo ren.kuo@quanta.corp-partner.google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: Ren Kuo ren.kuo@quanta.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Tim Chen tim-chen@quanta.corp-partner.google.com Gerrit-Comment-Date: Wed, 25 Dec 2019 02:40:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Ren Kuo (Code Review)

2:43 a.m.

Ren Kuo has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37808 )

Change subject: mb/google/octopus: Enable DRAM_PART_NUM_IN_CBI feature for Dood ......................................................................

Abandoned

the function had already opened in dood in all board veraions

-- To view, visit https://review.coreboot.org/c/coreboot/+/37808 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7c8fa254eff540f244b1f9c6229c11d07397b26 Gerrit-Change-Number: 37808 Gerrit-PatchSet: 2 Gerrit-Owner: Ren Kuo ren.kuo@quanta.corp-partner.google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: Ren Kuo ren.kuo@quanta.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Tim Chen tim-chen@quanta.corp-partner.google.com Gerrit-MessageType: abandon

1801

days inactive

1808

days old

coreboot-gerrit@coreboot.org

7 comments

2 participants

tags (0)

participants (2)

Henry Sun (Code Review)
Ren Kuo (Code Review)