Attention is currently required from: Nicholas Chin, Paul Menzel.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77444?usp=email )
Change subject: mb/dell: Add Latitude E6430 (Ivy Bridge) ......................................................................
Patch Set 6: Code-Review+2
(3 comments)
Patchset:
PS6: A couple of nits, Feel free to fix them in a follow-on patch if you're going to fix them. Overall, there are too many magic numbers for my taste, but that's very common in the sandybridge/ivybridge generations, so if you felt like fixing them, that would be great, but don't feel like you need to.
File src/mainboard/dell/e6430/cmos.layout:
https://review.coreboot.org/c/coreboot/+/77444/comment/090258dc_f7ba4a71 : PS6, Line 28: 5 nit: 414? Is there a reason to skip a bit here?
File src/mainboard/dell/e6430/early_init.c:
https://review.coreboot.org/c/coreboot/+/77444/comment/1f4cce92_39ef903e : PS6, Line 29: PCI_DEV(0, 0x1f, 0), 0x82, 0x1c0f Nit: These could be macros to better show what's being initialized.