Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35775 )
Change subject: soc/mediatek/mt8183: Add the shared 'dramc_param' module
......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35775/10/src/soc/mediatek/mt8183/in...
File src/soc/mediatek/mt8183/include/soc/dramc_param.h:
https://review.coreboot.org/c/coreboot/+/35775/10/src/soc/mediatek/mt8183/in...
PS10, Line 68: dramc_param
I think usually for 'ops' (see depthcharge) we won't put whole prarm struct here. It should be passed as a separate param, or a pointer to the real struct.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35775
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4cfd634da1855a76706aab0b050197251e2ed4dd
Gerrit-Change-Number: 35775
Gerrit-PatchSet: 10
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 08 Oct 2019 04:36:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment