Change in coreboot[master]: mb/ocp/tiogapass: Set BIOS_REGION_SIZE for FSP-T code caching
Johnny Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39628 )
Change subject: mb/ocp/tiogapass: Set BIOS_REGION_SIZE for FSP-T code caching ......................................................................
mb/ocp/tiogapass: Set BIOS_REGION_SIZE for FSP-T code caching
Tested on OCP Tioga Pass.
Change-Id: Id6070974db1db54cb12109044a1f720ee7585a1f Signed-off-by: Johnny Lin johnny_lin@wiwynn.com --- M src/mainboard/ocp/tiogapass/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/39628/1
diff --git a/src/mainboard/ocp/tiogapass/Kconfig b/src/mainboard/ocp/tiogapass/Kconfig index 87e2760..017d8c2 100644 --- a/src/mainboard/ocp/tiogapass/Kconfig +++ b/src/mainboard/ocp/tiogapass/Kconfig @@ -41,4 +41,8 @@ string default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/board.fmd"
+config BIOS_REGION_SIZE + hex + default 0x1000000 + endif # BOARD_OCP_TIOGAPASS
Hello build bot (Jenkins), Andrey Petrov, Jonathan Zhang, David Hendricks, Jingle Hsu, Morgan Jang, Andrey Petrov,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39628
to look at the new patch set (#2).
Change subject: mb/ocp/tiogapass: Set BIOS_REGION_SIZE for FSP-T code caching ......................................................................
mb/ocp/tiogapass: Set BIOS_REGION_SIZE for FSP-T code caching
Tested on OCP Tioga Pass.
Change-Id: Id6070974db1db54cb12109044a1f720ee7585a1f Signed-off-by: Johnny Lin johnny_lin@wiwynn.com --- M src/mainboard/ocp/tiogapass/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/39628/2
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39628 )
Change subject: mb/ocp/tiogapass: Set BIOS_REGION_SIZE for FSP-T code caching ......................................................................
Patch Set 2: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/39628/2/src/mainboard/ocp/tiogapass... File src/mainboard/ocp/tiogapass/Kconfig:
https://review.coreboot.org/c/coreboot/+/39628/2/src/mainboard/ocp/tiogapass... PS2, Line 44: config BIOS_REGION_SIZE If this is only used in one place and is constant, then a #define is preferable.
Johnny Lin has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/39628 )
Change subject: mb/ocp/tiogapass: Set BIOS_REGION_SIZE for FSP-T code caching ......................................................................
Abandoned
CACHE_ROM_SIZE already provides this need so abandoning this change.
-
David Hendricks (Code Review) -
Johnny Lin (Code Review)