Change in coreboot[master]: mainboard/google/puff: Configure HDA registers

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Edward O'Callaghan (Code Review)

20 Dec 2019 20 Dec '19

12:49 a.m.

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37859 )

Change subject: mainboard/google/puff: Configure HDA registers ......................................................................

mainboard/google/puff: Configure HDA registers

Enable PCH HDA and configure dmic+ssp registers.

BRANCH=none BUG=b:146519004 TEST=./util/abuild/abuild -p none -t google/hatch -x -a

Change-Id: If9495261201ca256cdb35352338c0b3a82a50196 Signed-off-by: Edward O'Callaghan quasisec@google.com --- M src/mainboard/google/hatch/variants/puff/overridetree.cb 1 file changed, 7 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/37859/1

diff --git a/src/mainboard/google/hatch/variants/puff/overridetree.cb b/src/mainboard/google/hatch/variants/puff/overridetree.cb index d791b7f..ab1837f 100644 --- a/src/mainboard/google/hatch/variants/puff/overridetree.cb +++ b/src/mainboard/google/hatch/variants/puff/overridetree.cb @@ -63,6 +63,13 @@ # [6:0] Rx Strobe Delay DLL 2(HS400 Mode), each 125ps, range: 0 - 39. register "common_soc_config.emmc_dll.emmc_rx_strobe_cntl" = "0x1515"

+ # Intel HDA + register "PchHdaDspEnable" = "1" + register "PchHdaAudioLinkSsp0" = "1" + register "PchHdaAudioLinkSsp1" = "0" + register "PchHdaAudioLinkDmic0" = "0" + register "PchHdaAudioLinkDmic1" = "0" + # Intel Common SoC Config #+-------------------+---------------------------+ #| Field | Value |

Attachments:

attachment.htm (text/html — 3.3 KB)

Show replies by date

Kangheui Won (Code Review)

20 Dec 20 Dec

1:35 a.m.

Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37859 )

Change subject: mainboard/google/puff: Configure HDA registers ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/37859 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If9495261201ca256cdb35352338c0b3a82a50196 Gerrit-Change-Number: 37859 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 20 Dec 2019 01:35:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Daniel Kurtz (Code Review)

21 Dec 21 Dec

5:58 a.m.

Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37859 )

Change subject: mainboard/google/puff: Configure HDA registers ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37859/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/37859/1/src/mainboard/google/hatch/... PS1, Line 66: # Intel HDA Curious, I would have expected this "overridetree.cb" to inherit some of these common registers from the hatch baseboard [0]. Perhaps we just need to disabled Ssp1 & Dmic0 here?

If so, can you also modify the comment to describe exactly what we are doing (cf the comment above the equivalent code block @ [0].

[0] https://cs.corp.google.com/chromeos_public/src/third_party/coreboot/src/main...

-- To view, visit https://review.coreboot.org/c/coreboot/+/37859 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If9495261201ca256cdb35352338c0b3a82a50196 Gerrit-Change-Number: 37859 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Daniel Kurtz djkurtz@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 21 Dec 2019 05:58:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Edward O'Callaghan (Code Review)

23 Dec 23 Dec

3:26 a.m.

Hello Kangheui Won, Shelley Chen, build bot (Jenkins), Patrick Georgi, Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37859

to look at the new patch set (#2).

Change subject: mainboard/google/puff: Configure HDA registers ......................................................................

mainboard/google/puff: Configure HDA registers

Enable PCH HDA and configure dmic+ssp registers.

BRANCH=none BUG=b:146519004 TEST=./util/abuild/abuild -p none -t google/hatch -x -a

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/37859/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/37859 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If9495261201ca256cdb35352338c0b3a82a50196 Gerrit-Change-Number: 37859 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Daniel Kurtz djkurtz@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Edward O'Callaghan (Code Review)

3:27 a.m.

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37859 )

Change subject: mainboard/google/puff: Configure HDA registers ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37859/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/37859/1/src/mainboard/google/hatch/... PS1, Line 66: # Intel HDA

...

Curious, I would have expected this "overridetree. […]

Your right, and so now that is done. Thanks for the review.

-- To view, visit https://review.coreboot.org/c/coreboot/+/37859 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If9495261201ca256cdb35352338c0b3a82a50196 Gerrit-Change-Number: 37859 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Daniel Kurtz djkurtz@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 23 Dec 2019 03:27:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Daniel Kurtz djkurtz@google.com Gerrit-MessageType: comment

Daniel Kurtz (Code Review)

3:30 a.m.

Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37859 )

Change subject: mainboard/google/puff: Configure HDA registers ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37859/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/37859/2/src/mainboard/google/hatch/... PS2, Line 71: Intel HDA Can you be a bit more descriptive what you are overriding for puff and why? See the baseboard for a pretty good example comment.

-- To view, visit https://review.coreboot.org/c/coreboot/+/37859 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If9495261201ca256cdb35352338c0b3a82a50196 Gerrit-Change-Number: 37859 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Daniel Kurtz djkurtz@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 23 Dec 2019 03:30:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Edward O'Callaghan (Code Review)

3:32 a.m.

Hello Kangheui Won, Shelley Chen, build bot (Jenkins), Patrick Georgi, Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37859

to look at the new patch set (#3).

Change subject: mainboard/google/puff: Configure HDA registers ......................................................................

mainboard/google/puff: Configure HDA registers

Enable PCH HDA and configure dmic+ssp registers.

BRANCH=none BUG=b:146519004 TEST=./util/abuild/abuild -p none -t google/hatch -x -a

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/37859/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/37859 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If9495261201ca256cdb35352338c0b3a82a50196 Gerrit-Change-Number: 37859 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Daniel Kurtz djkurtz@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Edward O'Callaghan (Code Review)

3:37 a.m.

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37859 )

Change subject: mainboard/google/puff: Configure HDA registers ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37859/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/37859/2/src/mainboard/google/hatch/... PS2, Line 71: Intel HDA

...

Can you be a bit more descriptive what you are overriding for puff and why? See the baseboard for a […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/37859 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If9495261201ca256cdb35352338c0b3a82a50196 Gerrit-Change-Number: 37859 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Daniel Kurtz djkurtz@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 23 Dec 2019 03:37:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Daniel Kurtz djkurtz@google.com Gerrit-MessageType: comment

Daniel Kurtz (Code Review)

4:21 a.m.

Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37859 )

Change subject: mainboard/google/puff: Configure HDA registers ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/37859 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If9495261201ca256cdb35352338c0b3a82a50196 Gerrit-Change-Number: 37859 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Daniel Kurtz djkurtz@google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 23 Dec 2019 04:21:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Edward O'Callaghan (Code Review)

10:09 p.m.

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37859 )

Change subject: mainboard/google/puff: Configure HDA registers ......................................................................

mainboard/google/puff: Configure HDA registers

Enable PCH HDA and configure dmic+ssp registers.

BRANCH=none BUG=b:146519004 TEST=./util/abuild/abuild -p none -t google/hatch -x -a

Change-Id: If9495261201ca256cdb35352338c0b3a82a50196 Signed-off-by: Edward O'Callaghan quasisec@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37859 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Daniel Kurtz djkurtz@google.com --- M src/mainboard/google/hatch/variants/puff/overridetree.cb 1 file changed, 4 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Daniel Kurtz: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/variants/puff/overridetree.cb b/src/mainboard/google/hatch/variants/puff/overridetree.cb index b99c1f2..342994d 100644 --- a/src/mainboard/google/hatch/variants/puff/overridetree.cb +++ b/src/mainboard/google/hatch/variants/puff/overridetree.cb @@ -68,6 +68,10 @@ # [6:0] Rx Strobe Delay DLL 2(HS400 Mode), each 125ps, range: 0 - 39. register "common_soc_config.emmc_dll.emmc_rx_strobe_cntl" = "0x1515"

+ # Intel HDA - disable I2S Audio SSP1 and DMIC0 as puff variant does not have them. + register "PchHdaAudioLinkSsp1" = "0" + register "PchHdaAudioLinkDmic0" = "0" + # Intel Common SoC Config #+-------------------+---------------------------+ #| Field | Value |

-- To view, visit https://review.coreboot.org/c/coreboot/+/37859 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If9495261201ca256cdb35352338c0b3a82a50196 Gerrit-Change-Number: 37859 Gerrit-PatchSet: 4 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Daniel Kurtz djkurtz@google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kangheui Won khwon@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1742

days inactive

1745

days old

coreboot-gerrit@coreboot.org

9 comments

3 participants

tags (0)

participants (3)

Daniel Kurtz (Code Review)
Edward O'Callaghan (Code Review)
Kangheui Won (Code Review)