HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61553 )
Change subject: src/security/intel: Get rid of unnecessary blank line after '{' ......................................................................
src/security/intel: Get rid of unnecessary blank line after '{'
Change-Id: I90c5f175f3f407673f5b6573afc985b104e1fdd5 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/security/intel/stm/SmmStm.c M src/security/intel/stm/StmPlatformResource.c M src/security/intel/stm/StmPlatformSmm.c M src/security/intel/txt/romstage.c 4 files changed, 0 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/61553/1
diff --git a/src/security/intel/stm/SmmStm.c b/src/security/intel/stm/SmmStm.c index 1ebe77d..74421c7 100644 --- a/src/security/intel/stm/SmmStm.c +++ b/src/security/intel/stm/SmmStm.c @@ -38,7 +38,6 @@ #define STM_SM_MONITOR_STATE_ENABLED 1
typedef struct { - uint64_t vmcs_revision_id : 31; uint64_t always_zero : 1; uint64_t vmcs_size : 13; @@ -482,7 +481,6 @@ return -1; // INVALID_PARAMETER;
if (m_stm_resources_ptr == NULL) { - // Copy EndResource for initialization m_stm_resources_ptr = stm_resource_heap; m_stm_resource_total_size = CONFIG_BIOS_RESOURCE_LIST_SIZE; @@ -648,7 +646,6 @@
if (stm_header->hw_stm_hdr.cr3_offset >= stm_header->sw_stm_hdr.static_image_size) { - // We will create page table, just in case that SINIT does not // create it. if (min_mseg_size < stm_header->hw_stm_hdr.cr3_offset diff --git a/src/security/intel/stm/StmPlatformResource.c b/src/security/intel/stm/StmPlatformResource.c index 75d52a2..7b3eee1 100644 --- a/src/security/intel/stm/StmPlatformResource.c +++ b/src/security/intel/stm/StmPlatformResource.c @@ -152,7 +152,6 @@ uint32_t Index;
for (Index = 0; Index < ARRAY_SIZE(msr_table); Index++) { - rsc_msr_tpl.msr_index = (uint32_t)msr_table[Index].msr_index; rsc_msr_tpl.read_mask = (uint64_t)msr_table[Index].read_mask; rsc_msr_tpl.write_mask = (uint64_t)msr_table[Index].write_mask; @@ -169,7 +168,6 @@ */ void add_resources_cmd(void) { - add_simple_resources();
add_msr_resources(); diff --git a/src/security/intel/stm/StmPlatformSmm.c b/src/security/intel/stm/StmPlatformSmm.c index cbb111a..2ca8673 100644 --- a/src/security/intel/stm/StmPlatformSmm.c +++ b/src/security/intel/stm/StmPlatformSmm.c @@ -157,7 +157,6 @@ }
if (cpu == 0) { - // need to create the BIOS resource list once // first calculate the location in SMRAM addr_calc = mseg - CONFIG_BIOS_RESOURCE_LIST_SIZE; diff --git a/src/security/intel/txt/romstage.c b/src/security/intel/txt/romstage.c index 98308b7..d4af667 100644 --- a/src/security/intel/txt/romstage.c +++ b/src/security/intel/txt/romstage.c @@ -107,13 +107,11 @@ const bool is_wake_error = !!(txt_ests & TXT_ESTS_WAKE_ERROR_STS);
if (CONFIG(INTEL_TXT_LOGGING)) { - printk(BIOS_INFO, "TEE-TXT: TPM established: %s\n", establishment ? "true" : "false"); }
if (establishment && is_wake_error) { - printk(BIOS_ERR, "TEE-TXT: Secrets remain in memory. SCLEAN is required.\n");
if (txt_ests & TXT_ESTS_TXT_RESET_STS) {