Change in coreboot[master]: mb/mainboard/hatch: add spd: 8G_3200 for Akemi

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Peichao Li (Code Review)

21 Sep 2019 21 Sep '19

3:47 a.m.

Peichao Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35511 )

Change subject: mb/mainboard/hatch: add spd: 8G_3200 for Akemi ......................................................................

mb/mainboard/hatch: add spd: 8G_3200 for Akemi

BUG=b:140545732 TEST=build bios and spd index set to 6, verify DUT bring up normally

Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I337b0bdcd37a9c4baacccbc6786968031a41b31e --- M src/mainboard/google/hatch/variants/akemi/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/35511/1

diff --git a/src/mainboard/google/hatch/variants/akemi/Makefile.inc b/src/mainboard/google/hatch/variants/akemi/Makefile.inc index 6cabe91..e86b4dd 100644 --- a/src/mainboard/google/hatch/variants/akemi/Makefile.inc +++ b/src/mainboard/google/hatch/variants/akemi/Makefile.inc @@ -18,6 +18,7 @@ SPD_SOURCES += 8G_2666 # 0b011 SPD_SOURCES += 16G_2400 # 0b100 SPD_SOURCES += 16G_2666 # 0b101 +SPD_SOURCES += 8G_3200 # 0b110

bootblock-y += gpio.c ramstage-y += gpio.c

Attachments:

attachment.htm (text/html — 2.5 KB)

Show replies by date

Philip Chen (Code Review)

21 Sep 21 Sep

4:03 a.m.

Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35511 )

Change subject: mb/mainboard/hatch: add spd: 8G_3200 for Akemi ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35511 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I337b0bdcd37a9c4baacccbc6786968031a41b31e Gerrit-Change-Number: 35511 Gerrit-PatchSet: 1 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Comment-Date: Sat, 21 Sep 2019 04:03:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Philip Chen (Code Review)

4:04 a.m.

Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35511 )

Change subject: mb/mainboard/hatch: add spd: 8G_3200 for Akemi ......................................................................

Patch Set 1: -Code-Review

-- To view, visit https://review.coreboot.org/c/coreboot/+/35511 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I337b0bdcd37a9c4baacccbc6786968031a41b31e Gerrit-Change-Number: 35511 Gerrit-PatchSet: 1 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 21 Sep 2019 04:04:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Philip Chen (Code Review)

4:05 a.m.

Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35511 )

Change subject: mb/mainboard/hatch: add spd: 8G_3200 for Akemi ......................................................................

Patch Set 1: Code-Review+1

LGTM

-- To view, visit https://review.coreboot.org/c/coreboot/+/35511 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I337b0bdcd37a9c4baacccbc6786968031a41b31e Gerrit-Change-Number: 35511 Gerrit-PatchSet: 1 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 21 Sep 2019 04:05:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Shelley Chen (Code Review)

4:14 a.m.

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35511 )

Change subject: mb/mainboard/hatch: add spd: 8G_3200 for Akemi ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35511 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I337b0bdcd37a9c4baacccbc6786968031a41b31e Gerrit-Change-Number: 35511 Gerrit-PatchSet: 1 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 21 Sep 2019 04:14:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

5:40 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35511 )

Change subject: mb/mainboard/hatch: add spd: 8G_3200 for Akemi ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35511/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/35511/1/src/mainboard/google/hatch/... PS1, Line 21: Please use tabs instead of spaces to keep it consistent with other entries above.

-- To view, visit https://review.coreboot.org/c/coreboot/+/35511 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I337b0bdcd37a9c4baacccbc6786968031a41b31e Gerrit-Change-Number: 35511 Gerrit-PatchSet: 1 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 21 Sep 2019 05:40:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Peichao Li (Code Review)

5:49 a.m.

Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35511 )

Change subject: mb/mainboard/hatch: add spd: 8G_3200 for Akemi ......................................................................

Patch Set 1:

...

Patch Set 1:

(1 comment)

Got it.

-- To view, visit https://review.coreboot.org/c/coreboot/+/35511 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I337b0bdcd37a9c4baacccbc6786968031a41b31e Gerrit-Change-Number: 35511 Gerrit-PatchSet: 1 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 21 Sep 2019 05:49:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Peichao Li (Code Review)

5:50 a.m.

Hello Paul Fagerburg, Philip Chen, Tim Wawrzynczak, Shelley Chen, build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35511

to look at the new patch set (#2).

Change subject: mb/mainboard/hatch: add spd: 8G_3200 for Akemi ......................................................................

mb/mainboard/hatch: add spd: 8G_3200 for Akemi

BUG=b:140545732 TEST=build bios and spd index set to 6, verify DUT bring up normally

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/35511/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35511 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I337b0bdcd37a9c4baacccbc6786968031a41b31e Gerrit-Change-Number: 35511 Gerrit-PatchSet: 2 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Furquan Shaikh (Code Review)

5:51 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35511 )

Change subject: mb/mainboard/hatch: add spd: 8G_3200 for Akemi ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35511 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I337b0bdcd37a9c4baacccbc6786968031a41b31e Gerrit-Change-Number: 35511 Gerrit-PatchSet: 2 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 21 Sep 2019 05:51:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Peichao Li (Code Review)

5:51 a.m.

Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35511 )

Change subject: mb/mainboard/hatch: add spd: 8G_3200 for Akemi ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35511/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/35511/1/src/mainboard/google/hatch/... PS1, Line 21:

...

Please use tabs instead of spaces to keep it consistent with other entries above.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/35511 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I337b0bdcd37a9c4baacccbc6786968031a41b31e Gerrit-Change-Number: 35511 Gerrit-PatchSet: 2 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 21 Sep 2019 05:51:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Patrick Georgi (Code Review)

22 Sep 22 Sep

8:13 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35511 )

Change subject: mb/mainboard/hatch: add spd: 8G_3200 for Akemi ......................................................................

mb/mainboard/hatch: add spd: 8G_3200 for Akemi

BUG=b:140545732 TEST=build bios and spd index set to 6, verify DUT bring up normally

Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I337b0bdcd37a9c4baacccbc6786968031a41b31e Reviewed-on: https://review.coreboot.org/c/coreboot/+/35511 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/akemi/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/variants/akemi/Makefile.inc b/src/mainboard/google/hatch/variants/akemi/Makefile.inc index 6cabe91..c9627c4 100644 --- a/src/mainboard/google/hatch/variants/akemi/Makefile.inc +++ b/src/mainboard/google/hatch/variants/akemi/Makefile.inc @@ -18,6 +18,7 @@ SPD_SOURCES += 8G_2666 # 0b011 SPD_SOURCES += 16G_2400 # 0b100 SPD_SOURCES += 16G_2666 # 0b101 +SPD_SOURCES += 8G_3200 # 0b110

bootblock-y += gpio.c ramstage-y += gpio.c

-- To view, visit https://review.coreboot.org/c/coreboot/+/35511 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I337b0bdcd37a9c4baacccbc6786968031a41b31e Gerrit-Change-Number: 35511 Gerrit-PatchSet: 3 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1833

days inactive

1834

days old

coreboot-gerrit@coreboot.org

10 comments

5 participants

tags (0)

participants (5)

Furquan Shaikh (Code Review)
Patrick Georgi (Code Review)
Peichao Li (Code Review)
Philip Chen (Code Review)
Shelley Chen (Code Review)