Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63631 )
Change subject: soc/intel/{skl, xeon_sp}: Drop SoC specific LPC lock down configuration ......................................................................
soc/intel/{skl, xeon_sp}: Drop SoC specific LPC lock down configuration
This patch drops SoC specific lpc lock down configuration as commit 63630 (soc/intel/cmn/pch/lockdown: Implement LPC lock down configuration) implements the lpc registers lock down configuration in common code.
BUG=b:211954778 TEST=Build.
Signed-off-by: Subrata Banik subratabanik@google.com Change-Id: I99ec6d63dfe9a8ac8d9846067a9afc3ef83dc1c2 Reviewed-on: https://review.coreboot.org/c/coreboot/+/63631 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Lean Sheng Tan sheng.tan@9elements.com Reviewed-by: Marc Jones marc@marcjonesconsulting.com Reviewed-by: Paul Menzel paulepanter@mailbox.org --- M src/soc/intel/skylake/lockdown.c M src/soc/intel/xeon_sp/lockdown.c 2 files changed, 0 insertions(+), 24 deletions(-)
Approvals: build bot (Jenkins): Verified Marc Jones: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Lean Sheng Tan: Looks good to me, approved
diff --git a/src/soc/intel/skylake/lockdown.c b/src/soc/intel/skylake/lockdown.c index 2fa53c9..1dd4e56 100644 --- a/src/soc/intel/skylake/lockdown.c +++ b/src/soc/intel/skylake/lockdown.c @@ -2,20 +2,10 @@
#include <device/mmio.h> #include <intelblocks/cfg.h> -#include <intelblocks/lpc_lib.h> #include <intelblocks/pmclib.h> #include <intelpch/lockdown.h> #include <soc/pm.h>
-static void lpc_lockdown_config(int chipset_lockdown) -{ - /* Set BIOS Interface Lock, BIOS Lock */ - if (chipset_lockdown == CHIPSET_LOCKDOWN_COREBOOT) { - lpc_set_bios_interface_lock_down(); - lpc_set_lock_enable(); - } -} - static void pmc_lockdown_config(void) { uint8_t *pmcbase; @@ -33,9 +23,6 @@
void soc_lockdown_config(int chipset_lockdown) { - /* LPC lock down configuration */ - lpc_lockdown_config(chipset_lockdown); - /* PMC lock down configuration */ pmc_lockdown_config(); } diff --git a/src/soc/intel/xeon_sp/lockdown.c b/src/soc/intel/xeon_sp/lockdown.c index 0f032fc..49f3f5a 100644 --- a/src/soc/intel/xeon_sp/lockdown.c +++ b/src/soc/intel/xeon_sp/lockdown.c @@ -3,21 +3,11 @@ #include <device/mmio.h> #include <device/pci.h> #include <intelblocks/cfg.h> -#include <intelblocks/lpc_lib.h> #include <intelblocks/pmclib.h> #include <intelpch/lockdown.h> #include <soc/pci_devs.h> #include <soc/pm.h>
-static void lpc_lockdown_config(int chipset_lockdown) -{ - /* Set BIOS Interface Lock, BIOS Lock */ - if (chipset_lockdown == CHIPSET_LOCKDOWN_COREBOOT) { - lpc_set_bios_interface_lock_down(); - lpc_set_lock_enable(); - } -} - static void pmc_lockdown_config(int chipset_lockdown) { uint8_t *pmcbase; @@ -46,7 +36,6 @@
void soc_lockdown_config(int chipset_lockdown) { - lpc_lockdown_config(chipset_lockdown); pmc_lockdown_config(chipset_lockdown); sata_lockdown_config(chipset_lockdown); }
5 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.