Change in coreboot[master]: Coachz: change EN_PP3300_DX_EDP from gpio52 to gpio67

[Bob Moragues (Code Review)]

Hello Bob Moragues,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/48224

to review the following change.

Change subject: Coachz: change EN_PP3300_DX_EDP from gpio52 to gpio67
......................................................................

Coachz: change EN_PP3300_DX_EDP from gpio52 to gpio67

Coachz rev1 has changed EN_PP3300_DX_EDP from gpio52 to gpio67.

BRANCH=none
BUG=b:174123578
TEST=emerge-strongbad coreboot chromeos-bootimage.
flash coreboot and boot up normally.

Signed-off-by: yuanliding

Change-Id: I32a721d0d725bf217debe35a5cdc01aa8f5d5daf
---
M src/mainboard/google/trogdor/board.h
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/48224/1

diff --git a/src/mainboard/google/trogdor/board.h b/src/mainboard/google/trogdor/board.h
index 4d38378..ebce3b5 100644
--- a/src/mainboard/google/trogdor/board.h
+++ b/src/mainboard/google/trogdor/board.h
@@ -17,7 +17,8 @@
 #define GPIO_BACKLIGHT_ENABLE  GPIO(12)
 #define GPIO_EDP_BRIDGE_ENABLE (CONFIG(TROGDOR_REV0) ? GPIO(14) : GPIO(104))
 #define GPIO_EN_PP3300_DX_EDP  (CONFIG(TROGDOR_REV0) ? GPIO(106) : \
-	(CONFIG(BOARD_GOOGLE_COACHZ) ? GPIO(52) : GPIO(30)))
+	(CONFIG(BOARD_GOOGLE_COACHZ) ? (board_id() == 0 ? GPIO(52) : \
+	GPIO(67)) : GPIO(30)))

void setup_chromeos_gpios(void);

[Shelley Chen (Code Review)]

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48224 )

Change subject: Coachz: change EN_PP3300_DX_EDP from gpio52 to gpio67
......................................................................

Patch Set 1: Code-Review+2

[Philip Chen (Code Review)]

Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48224 )

Change subject: Coachz: change EN_PP3300_DX_EDP from gpio52 to gpio67
......................................................................

Patch Set 1:

Ping, can we merge this patch?
Otherwise, we can't complete the factory process for the ongoing coachz build.

[Julius Werner (Code Review)]

Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48224 )

Change subject: Coachz: change EN_PP3300_DX_EDP from gpio52 to gpio67
......................................................................

Coachz: change EN_PP3300_DX_EDP from gpio52 to gpio67

Coachz rev1 has changed EN_PP3300_DX_EDP from gpio52 to gpio67.

BRANCH=none
BUG=b:174123578
TEST=emerge-strongbad coreboot chromeos-bootimage.
flash coreboot and boot up normally.

Signed-off-by: yuanliding

Change-Id: I32a721d0d725bf217debe35a5cdc01aa8f5d5daf
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48224
Tested-by: build bot (Jenkins) 
Reviewed-by: Shelley Chen 
---
M src/mainboard/google/trogdor/board.h
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Shelley Chen: Looks good to me, approved

diff --git a/src/mainboard/google/trogdor/board.h b/src/mainboard/google/trogdor/board.h
index 4d38378..ebce3b5 100644
--- a/src/mainboard/google/trogdor/board.h
+++ b/src/mainboard/google/trogdor/board.h
@@ -17,7 +17,8 @@
 #define GPIO_BACKLIGHT_ENABLE  GPIO(12)
 #define GPIO_EDP_BRIDGE_ENABLE (CONFIG(TROGDOR_REV0) ? GPIO(14) : GPIO(104))
 #define GPIO_EN_PP3300_DX_EDP  (CONFIG(TROGDOR_REV0) ? GPIO(106) : \
-	(CONFIG(BOARD_GOOGLE_COACHZ) ? GPIO(52) : GPIO(30)))
+	(CONFIG(BOARD_GOOGLE_COACHZ) ? (board_id() == 0 ? GPIO(52) : \
+	GPIO(67)) : GPIO(30)))

void setup_chromeos_gpios(void);