HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43941 )
Change subject: sb/intel: Add missing '#include <stddef.h>' ......................................................................
sb/intel: Add missing '#include <stddef.h>'
size_t needs <stddef.h>.
Change-Id: Ifb14124fcb2b6a7cbd7f172fe47b4016d159cf1d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/intel/bd82x6x/lpc.c M src/southbridge/intel/common/spi.c M src/southbridge/intel/lynxpoint/lpc.c 3 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/43941/1
diff --git a/src/southbridge/intel/bd82x6x/lpc.c b/src/southbridge/intel/bd82x6x/lpc.c index 2407d92..abf88f8 100644 --- a/src/southbridge/intel/bd82x6x/lpc.c +++ b/src/southbridge/intel/bd82x6x/lpc.c @@ -16,6 +16,7 @@ #include <acpi/acpigen.h> #include <cpu/x86/smm.h> #include <cbmem.h> +#include <stddef.h> #include <string.h> #include "chip.h" #include "pch.h" diff --git a/src/southbridge/intel/common/spi.c b/src/southbridge/intel/common/spi.c index 380940c..1ce2d9d 100644 --- a/src/southbridge/intel/common/spi.c +++ b/src/southbridge/intel/common/spi.c @@ -16,6 +16,7 @@ #include <device/pci.h> #include <spi_flash.h> #include <spi-generic.h> +#include <stddef.h> #include <timer.h>
#include "spi.h" diff --git a/src/southbridge/intel/lynxpoint/lpc.c b/src/southbridge/intel/lynxpoint/lpc.c index 7082a79..1235fac 100644 --- a/src/southbridge/intel/lynxpoint/lpc.c +++ b/src/southbridge/intel/lynxpoint/lpc.c @@ -14,6 +14,7 @@ #include <acpi/acpi_gnvs.h> #include <cpu/x86/smm.h> #include <cbmem.h> +#include <stddef.h> #include <string.h> #include "chip.h" #include "nvs.h"
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43941
to look at the new patch set (#2).
Change subject: sb/intel: Add missing '#include <{stdbool,stddef,stdint}.h>' ......................................................................
sb/intel: Add missing '#include <{stdbool,stddef,stdint}.h>'
Include <types.h> when stddef, stdint and stdbool are needed.
Change-Id: Ifb14124fcb2b6a7cbd7f172fe47b4016d159cf1d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/intel/bd82x6x/lpc.c M src/southbridge/intel/common/spi.c M src/southbridge/intel/i82801gx/sata.c M src/southbridge/intel/lynxpoint/chip.h M src/southbridge/intel/lynxpoint/lpc.c M src/southbridge/intel/lynxpoint/pcie.c 6 files changed, 9 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/43941/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43941 )
Change subject: sb/intel: Add missing '#include <{stdbool,stddef,stdint}.h>' ......................................................................
Patch Set 2:
(9 comments)
I've added comments to make the review easy
https://review.coreboot.org/c/coreboot/+/43941/2/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/lpc.c:
https://review.coreboot.org/c/coreboot/+/43941/2/src/southbridge/intel/bd82x... PS2, Line 352: size_t stdded
https://review.coreboot.org/c/coreboot/+/43941/2/src/southbridge/intel/commo... File src/southbridge/intel/common/spi.c:
https://review.coreboot.org/c/coreboot/+/43941/2/src/southbridge/intel/commo... PS2, Line 524: size_t stddef
https://review.coreboot.org/c/coreboot/+/43941/2/src/southbridge/intel/i8280... File src/southbridge/intel/i82801gx/sata.c:
https://review.coreboot.org/c/coreboot/+/43941/2/src/southbridge/intel/i8280... PS2, Line 15: u8 stdint
https://review.coreboot.org/c/coreboot/+/43941/2/src/southbridge/intel/i8280... PS2, Line 52: bool stdbool
https://review.coreboot.org/c/coreboot/+/43941/2/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/chip.h:
https://review.coreboot.org/c/coreboot/+/43941/2/src/southbridge/intel/lynxp... PS2, Line 105: bool stdbool
https://review.coreboot.org/c/coreboot/+/43941/2/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/lpc.c:
https://review.coreboot.org/c/coreboot/+/43941/2/src/southbridge/intel/lynxp... PS2, Line 371: size_t stddef
https://review.coreboot.org/c/coreboot/+/43941/2/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/pcie.c:
https://review.coreboot.org/c/coreboot/+/43941/2/src/southbridge/intel/lynxp... PS2, Line 22: u32 stdint
https://review.coreboot.org/c/coreboot/+/43941/2/src/southbridge/intel/lynxp... PS2, Line 63: bool stdbool
https://review.coreboot.org/c/coreboot/+/43941/2/src/southbridge/intel/lynxp... PS2, Line 67: NULL stddef
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43941
to look at the new patch set (#3).
Change subject: sb/intel: Add missing '#include <{stdbool,stddef,stdint}.h>' ......................................................................
sb/intel: Add missing '#include <{stdbool,stddef,stdint}.h>'
Include <types.h> when stddef, stdint and stdbool are needed.
Change-Id: Ifb14124fcb2b6a7cbd7f172fe47b4016d159cf1d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/intel/bd82x6x/lpc.c M src/southbridge/intel/common/spi.c M src/southbridge/intel/i82801gx/sata.c M src/southbridge/intel/lynxpoint/chip.h M src/southbridge/intel/lynxpoint/lpc.c M src/southbridge/intel/lynxpoint/pcie.c 6 files changed, 8 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/43941/3
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43941 )
Change subject: sb/intel: Add missing '#include <{stdbool,stddef,stdint}.h>' ......................................................................
Abandoned
-
HAOUAS Elyes (Code Review)