Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31936 )
Change subject: [RFC] util/sconfig: Drop topology from early static tree ......................................................................
Patch Set 7: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/31936/7/src/Kconfig File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/31936/7/src/Kconfig@415 PS7, Line 415: def_bool n Maybe add some help text here, to know when this should be selected?
https://review.coreboot.org/c/coreboot/+/31936/7/src/include/device/device.h File src/include/device/device.h:
https://review.coreboot.org/c/coreboot/+/31936/7/src/include/device/device.h... PS7, Line 128: DEVTREE_CONST struct bus *bus; /* bus this device is on, for bridge I'd move these comments to the previous line, maybe they fit in one line
https://review.coreboot.org/c/coreboot/+/31936/7/src/include/device/device.h... PS7, Line 129: up stream I've usually seen it in one word: "upstream"
-
Angel Pons (Code Review)