Attention is currently required from: Intel coreboot Reviewers, Kapil Porwal, Subrata Banik.
Dinesh Gehlot has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/86153?usp=email )
Change subject: soc/intel/cmn/blk: Refactor CSE status flag and optimize forced sync
......................................................................
Patch Set 15:
(2 comments)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/86153/comment/b25cc5cb_3b587c11?usp... :
PS12, Line 751: if ((vb2api_gbb_get_flags(ctx) & VB2_GBB_FLAG_FORCE_CSE_SYNC) &&
: cse_get_current_bp() == RO) {
We use `is_cse_sync_enforced()` to determine if a forced CSE sync is pending, regardless of the boot […]
Resolving the comment assuming no further query.
https://review.coreboot.org/c/coreboot/+/86153/comment/750b125b_7181edbc?usp... :
PS12, Line 765: is_cse_sync_enforced
The status update has been decoupled from is_cse_sync_enforced() as `cmos_update_cse_sync_status()`. […]
Resolving the comment assuming no further query.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86153?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If1e4180cb5fec3990fdee2b0e412173b1c8c6ded
Gerrit-Change-Number: 86153
Gerrit-PatchSet: 15
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Wed, 09 Apr 2025 13:49:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Dinesh Gehlot
digehlot@google.com