New patch to review for coreboot: 4018577 pit: Stop calling tps65090 functions until we can call through the EC.

[Gabe Black]

Gabe Black ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3686

-gerrit

commit 4018577444da94a0ccc1dce42e910aa8edce0356
Author: Gabe Black 
Date:   Wed Jun 19 02:10:36 2013 -0700

pit: Stop calling tps65090 functions until we can call through the EC.

On pit, the tps65090 is connected to the EC and has to be accessed by proxy.
    Until we have that implemented, this change removes calls to tps69050 which
    will never succeed, and stops compiling in the driver.

Change-Id: I7218f85f9f26623bd13aaaf8ded0638b3b2f874a
    Signed-off-by: Gabe Black 
---
 src/mainboard/google/pit/Kconfig     |  1 -
 src/mainboard/google/pit/mainboard.c | 26 ++------------------------
 2 files changed, 2 insertions(+), 25 deletions(-)

diff --git a/src/mainboard/google/pit/Kconfig b/src/mainboard/google/pit/Kconfig
index 0dc013b..b3094a2 100644
--- a/src/mainboard/google/pit/Kconfig
+++ b/src/mainboard/google/pit/Kconfig
@@ -29,7 +29,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
    select BOARD_ROMSIZE_KB_4096
    select DRIVER_MAXIM_MAX77686
    select CHROMEOS
-	select DRIVER_TI_TPS65090
    select MAINBOARD_HAS_NATIVE_VGA_INIT
    select MAINBOARD_DO_NATIVE_VGA_INIT
    select HAVE_INIT_TIMER
diff --git a/src/mainboard/google/pit/mainboard.c b/src/mainboard/google/pit/mainboard.c
index 7743864..f0df039 100644
--- a/src/mainboard/google/pit/mainboard.c
+++ b/src/mainboard/google/pit/mainboard.c
@@ -20,7 +20,6 @@
 #include <console/console.h>
 #include <device/device.h>
 #include <device/i2c.h>
-#include <drivers/ti/tps65090/tps65090.h>
 #include <cbmem.h>
 #include <delay.h>
 #include <edid.h>
@@ -126,24 +125,6 @@ static void backlight_en(void)
    gpio_direction_output(GPIO_X30, 1);
 }

-#define TPS69050_BUS	4	/* Pit-specific */
-
-#define FET1_CTRL	0x0f
-#define FET6_CTRL	0x14
-
-static void lcd_vdd(void)
-{
-	/* Enable FET6, lcd panel */
-	tps65090_fet_enable(TPS69050_BUS, FET6_CTRL);
-}
-
-static void backlight_vdd(void)
-{
-	/* Enable FET1, backlight */
-	tps65090_fet_enable(TPS69050_BUS, FET1_CTRL);
-	udelay(LCD_T5_DELAY_MS * 1000);
-}
-
 //static struct video_info smdk5420_dp_config = {
 static struct video_info dp_video_info = {
    /* FIXME: fix video_info struct to use const for name */
@@ -186,9 +167,6 @@ static void mainboard_init(device_t dev)
    };
    void *fb_addr;

-	i2c_init(TPS69050_BUS, I2C_0_SPEED, I2C_SLAVE);
-	i2c_init(7, I2C_0_SPEED, I2C_SLAVE);
-
    tmu_init(&exynos5420_tmu_info);

/* Clock Gating all the unused IP's to save power */
@@ -200,7 +178,7 @@ static void mainboard_init(device_t dev)
    fb_addr = cbmem_find(CBMEM_ID_CONSOLE);
    set_vbe_mode_info_valid(&edid, (uintptr_t)fb_addr);

-	lcd_vdd();
+	// XXX Turn on the LCD power here.

// FIXME: should timeout
    do {
@@ -220,7 +198,7 @@ static void mainboard_init(device_t dev)

udelay(LCD_T3_DELAY_MS * 1000);

-		backlight_vdd();
+		// XXX Turn on the backlight power here.
    	backlight_pwm();
    	backlight_en();
    	/* if we're here, we're successful */