Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Martin Roth, Matt DeVillier, Maximilian Brune, Raul Rangel.
Patrick Rudolph has posted comments on this change by Fred Reitberger. ( https://review.coreboot.org/c/coreboot/+/68122?usp=email )
Change subject: soc/amd/common: Support sbin ucode files
......................................................................
Patch Set 9:
(4 comments)
File src/soc/amd/common/block/cpu/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/68122/comment/c6794507_331b6537?usp... :
PS2, Line 21: hexdump
I tried `dd` and `printf` in the shell and couldn't get it to work, but I did find another solution […]
Done
File src/soc/amd/common/block/cpu/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/68122/comment/5510864d_44eaebd1?usp... :
PS5, Line 20: ucode
This kind of shell code (if else stuff) is arguable harder to read if directly included inside the M […]
Done
https://review.coreboot.org/c/coreboot/+/68122/comment/f3eb6cef_f3b1cfbd?usp... :
PS5, Line 41: $(amd_microcode_bins)
Doesn't that make it unnecessarily complicated? We would still need 2 loops to filter sbin and bin. […]
Done
https://review.coreboot.org/c/coreboot/+/68122/comment/9c9c61a4_a6b673fe?usp... :
PS5, Line 43: $(amd_microcode_sbins)
$(filter %. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68122?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I29768ea19543bdc76662e687f59bf31b76f555ae
Gerrit-Change-Number: 68122
Gerrit-PatchSet: 9
Gerrit-Owner: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 04 Feb 2025 06:50:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com
Comment-In-Reply-To: Fred Reitberger
reitbergerfred@gmail.com