Change in coreboot[master]: src/drivers: Add missing '#include <{stdbool,stddef,stdint}.h>'
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43967 )
Change subject: src/drivers: Add missing '#include <{stdbool,stddef,stdint}.h>' ......................................................................
src/drivers: Add missing '#include <{stdbool,stddef,stdint}.h>'
Include <types.h> when stddef, stdint and stdbool are needed.
Change-Id: Ic251fe12777f03c4a14dd707be66f6e9223cd7df Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/aspeed/common/ast_dp501.c M src/drivers/aspeed/common/ast_drv.h M src/drivers/aspeed/common/ast_main.c M src/drivers/aspeed/common/ast_mode.c M src/drivers/aspeed/common/ast_mode_corebootfb.c M src/drivers/aspeed/common/ast_post.c M src/drivers/elog/elog.c M src/drivers/generic/gpio_keys/chip.h M src/drivers/i2c/generic/chip.h M src/drivers/i2c/generic/generic.c M src/drivers/i2c/max98373/chip.h M src/drivers/i2c/max98927/chip.h M src/drivers/intel/dptf/chip.h M src/drivers/intel/dptf/dptf.c M src/drivers/intel/fsp1_1/hob.c M src/drivers/intel/fsp1_1/include/fsp/romstage.h M src/drivers/intel/fsp1_1/raminit.c M src/drivers/intel/fsp1_1/romstage.c M src/drivers/intel/fsp2_0/hand_off_block.c M src/drivers/intel/fsp2_0/include/fsp/api.h M src/drivers/intel/mipi_camera/chip.h M src/drivers/intel/ptt/ptt.c M src/drivers/intel/ptt/ptt.h M src/drivers/ipmi/chip.h M src/drivers/lenovo/hybrid_graphics/hybrid_graphics.h M src/drivers/mrc_cache/mrc_cache.c M src/drivers/net/chip.h M src/drivers/ocp/dmi/smbios.c M src/drivers/spi/acpi/acpi.c M src/drivers/spi/acpi/chip.h M src/drivers/spi/boot_device_rw_nommap.c M src/drivers/spi/cbfs_spi.c M src/drivers/spi/spi-generic.c M src/drivers/spi/winbond.c M src/drivers/uart/acpi/acpi.c M src/drivers/uart/acpi/chip.h M src/drivers/usb/acpi/chip.h M src/drivers/usb/acpi/usb_acpi.c M src/drivers/usb/ehci_debug.c M src/drivers/usb/pci_xhci/pci_xhci.c M src/drivers/vpd/vpd.c 41 files changed, 63 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/43967/1
diff --git a/src/drivers/aspeed/common/ast_dp501.c b/src/drivers/aspeed/common/ast_dp501.c index 460b858..55fe845 100644 --- a/src/drivers/aspeed/common/ast_dp501.c +++ b/src/drivers/aspeed/common/ast_dp501.c @@ -7,6 +7,7 @@ */
#include <delay.h> +#include <types.h>
#include "ast_drv.h"
diff --git a/src/drivers/aspeed/common/ast_drv.h b/src/drivers/aspeed/common/ast_drv.h index e275108..bd3e4b2 100644 --- a/src/drivers/aspeed/common/ast_drv.h +++ b/src/drivers/aspeed/common/ast_drv.h @@ -5,6 +5,9 @@ #ifndef __AST_DRV_H__ #define __AST_DRV_H__
+#include <stdbool.h> +#include <stdint.h> + #include "aspeed_coreboot.h"
#define PCI_CHIP_AST2000 0x2000 diff --git a/src/drivers/aspeed/common/ast_main.c b/src/drivers/aspeed/common/ast_main.c index 5143e6d..41b7e09 100644 --- a/src/drivers/aspeed/common/ast_main.c +++ b/src/drivers/aspeed/common/ast_main.c @@ -4,6 +4,7 @@ */
#include <delay.h> +#include <types.h>
#include "ast_drv.h" #include "ast_dram_tables.h" diff --git a/src/drivers/aspeed/common/ast_mode.c b/src/drivers/aspeed/common/ast_mode.c index 465d886..3eb9ade 100644 --- a/src/drivers/aspeed/common/ast_mode.c +++ b/src/drivers/aspeed/common/ast_mode.c @@ -3,6 +3,9 @@ * Copied from Linux drivers/gpu/drm/ast/ast_mode.c * Please try to keep as close as possible to the upstream source. */ + +#include <types.h> + #include "ast_drv.h" #include "ast_tables.h"
diff --git a/src/drivers/aspeed/common/ast_mode_corebootfb.c b/src/drivers/aspeed/common/ast_mode_corebootfb.c index 2a033a0..dbe6e6b 100644 --- a/src/drivers/aspeed/common/ast_mode_corebootfb.c +++ b/src/drivers/aspeed/common/ast_mode_corebootfb.c @@ -3,6 +3,8 @@ * Copied from Linux drivers/gpu/drm/ast/ast_mode.c */ #include <edid.h> +#include <stdbool.h> +#include <stdint.h>
#include "ast_drv.h"
diff --git a/src/drivers/aspeed/common/ast_post.c b/src/drivers/aspeed/common/ast_post.c index b3b7d61..2db99ea 100644 --- a/src/drivers/aspeed/common/ast_post.c +++ b/src/drivers/aspeed/common/ast_post.c @@ -3,6 +3,8 @@ #define COREBOOT_AST_FAILOVER_TIMEOUT 10000000
#include <delay.h> +#include <stdbool.h> +#include <stdint.h>
#include "ast_drv.h" #include "ast_dram_tables.h" diff --git a/src/drivers/elog/elog.c b/src/drivers/elog/elog.c index 01fa9cc..00bc0e9 100644 --- a/src/drivers/elog/elog.c +++ b/src/drivers/elog/elog.c @@ -12,9 +12,10 @@ #include <post.h> #include <rtc.h> #include <smbios.h> -#include <stdint.h> #include <string.h> #include <elog.h> +#include <types.h> + #include "elog_internal.h"
diff --git a/src/drivers/generic/gpio_keys/chip.h b/src/drivers/generic/gpio_keys/chip.h index a2ff59d..1198f88 100644 --- a/src/drivers/generic/gpio_keys/chip.h +++ b/src/drivers/generic/gpio_keys/chip.h @@ -4,6 +4,7 @@ #define __DRIVERS_GENERIC_GPIO_KEYS_H__
#include <acpi/acpi_device.h> +#include <stdbool.h> #include <stdint.h>
/* Linux input type */ diff --git a/src/drivers/i2c/generic/chip.h b/src/drivers/i2c/generic/chip.h index 284c9d1..c290ae2 100644 --- a/src/drivers/i2c/generic/chip.h +++ b/src/drivers/i2c/generic/chip.h @@ -5,6 +5,7 @@
#include <acpi/acpi_device.h> #include <device/i2c_simple.h> +#include <stdbool.h>
#define MAX_GENERIC_PROPERTY_LIST 10
diff --git a/src/drivers/i2c/generic/generic.c b/src/drivers/i2c/generic/generic.c index 18fd55c..8cfae19 100644 --- a/src/drivers/i2c/generic/generic.c +++ b/src/drivers/i2c/generic/generic.c @@ -7,7 +7,10 @@ #include <device/device.h> #include <device/path.h> #include <gpio.h> +#include <stdbool.h> +#include <stddef.h> #include <string.h> + #include "chip.h"
#if CONFIG(HAVE_ACPI_TABLES) diff --git a/src/drivers/i2c/max98373/chip.h b/src/drivers/i2c/max98373/chip.h index c184531..dbb103b 100644 --- a/src/drivers/i2c/max98373/chip.h +++ b/src/drivers/i2c/max98373/chip.h @@ -4,6 +4,7 @@ * Maxim MAX98373 audio codec devicetree bindings */
+#include <stdbool.h> #include <stdint.h>
struct drivers_i2c_max98373_config { diff --git a/src/drivers/i2c/max98927/chip.h b/src/drivers/i2c/max98927/chip.h index fcdb9e0..c3ed785 100644 --- a/src/drivers/i2c/max98927/chip.h +++ b/src/drivers/i2c/max98927/chip.h @@ -3,6 +3,9 @@ /* * Maxim MAX98927 audio codec devicetree bindings */ + +#include <stdbool.h> + struct drivers_i2c_max98927_config { /* I2C Bus Frequency in Hertz (default 400kHz) */ unsigned int bus_speed; diff --git a/src/drivers/intel/dptf/chip.h b/src/drivers/intel/dptf/chip.h index db4c3ae..5ebd3ec 100644 --- a/src/drivers/intel/dptf/chip.h +++ b/src/drivers/intel/dptf/chip.h @@ -4,6 +4,8 @@ #define _DRIVERS_INTEL_DPTF_CHIP_H_
#include <acpi/acpigen_dptf.h> +#include <stdbool.h> +#include <stdint.h> #include <timer.h> /* for MSECS_PER_SEC */
#define DPTF_PASSIVE(src, tgt, tmp, prd) \ diff --git a/src/drivers/intel/dptf/dptf.c b/src/drivers/intel/dptf/dptf.c index 0f1cc9c..cb07310 100644 --- a/src/drivers/intel/dptf/dptf.c +++ b/src/drivers/intel/dptf/dptf.c @@ -3,6 +3,9 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/device.h> +#include <stdbool.h> +#include <stddef.h> + #include "chip.h"
/* Generic DPTF participants have a PTYP field to distinguish them */ diff --git a/src/drivers/intel/fsp1_1/hob.c b/src/drivers/intel/fsp1_1/hob.c index 9a09cfd..d7cb9ce 100644 --- a/src/drivers/intel/fsp1_1/hob.c +++ b/src/drivers/intel/fsp1_1/hob.c @@ -5,6 +5,7 @@ #include <fsp/util.h> #include <ip_checksum.h> #include <string.h> +#include <types.h>
/* Compares two EFI GUIDs. Returns true of the GUIDs match, false otherwise. */ static bool compare_guid(const EFI_GUID *guid1, const EFI_GUID *guid2) diff --git a/src/drivers/intel/fsp1_1/include/fsp/romstage.h b/src/drivers/intel/fsp1_1/include/fsp/romstage.h index c452f0b..aee7b02 100644 --- a/src/drivers/intel/fsp1_1/include/fsp/romstage.h +++ b/src/drivers/intel/fsp1_1/include/fsp/romstage.h @@ -3,8 +3,7 @@ #ifndef _COMMON_ROMSTAGE_H_ #define _COMMON_ROMSTAGE_H_
-#include <stddef.h> -#include <stdint.h> +#include <types.h> #include <memory_info.h> #include <fsp/car.h> #include <fsp/util.h> diff --git a/src/drivers/intel/fsp1_1/raminit.c b/src/drivers/intel/fsp1_1/raminit.c index dd08d77..c21d8b0 100644 --- a/src/drivers/intel/fsp1_1/raminit.c +++ b/src/drivers/intel/fsp1_1/raminit.c @@ -11,6 +11,7 @@ #include <lib.h> /* hexdump */ #include <string.h> #include <timestamp.h> +#include <types.h>
void raminit(struct romstage_params *params) { diff --git a/src/drivers/intel/fsp1_1/romstage.c b/src/drivers/intel/fsp1_1/romstage.c index 46df1c8..62b6c16 100644 --- a/src/drivers/intel/fsp1_1/romstage.c +++ b/src/drivers/intel/fsp1_1/romstage.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <stddef.h> #include <acpi/acpi.h> #include <assert.h> #include <console/console.h> @@ -18,6 +17,7 @@ #include <stage_cache.h> #include <string.h> #include <timestamp.h> +#include <types.h> #include <vendorcode/google/chromeos/chromeos.h>
static void raminit_common(struct romstage_params *params) diff --git a/src/drivers/intel/fsp2_0/hand_off_block.c b/src/drivers/intel/fsp2_0/hand_off_block.c index 44c91a2..9e9bf0f 100644 --- a/src/drivers/intel/fsp2_0/hand_off_block.c +++ b/src/drivers/intel/fsp2_0/hand_off_block.c @@ -6,8 +6,8 @@ #include <console/console.h> #include <fsp/api.h> #include <fsp/util.h> -#include <stdint.h> #include <string.h> +#include <types.h>
#define HOB_HEADER_LEN 8
diff --git a/src/drivers/intel/fsp2_0/include/fsp/api.h b/src/drivers/intel/fsp2_0/include/fsp/api.h index d2c556f..3d33871 100644 --- a/src/drivers/intel/fsp2_0/include/fsp/api.h +++ b/src/drivers/intel/fsp2_0/include/fsp/api.h @@ -3,10 +3,9 @@ #ifndef _FSP2_0_API_H_ #define _FSP2_0_API_H_
-#include <stddef.h> -#include <stdint.h> #include <fsp/soc_binding.h> #include <soc/intel/common/mma.h> +#include <types.h>
#define FSP_SUCCESS EFI_SUCCESS #define FSP_INVALID_PARAMETER EFI_INVALID_PARAMETER diff --git a/src/drivers/intel/mipi_camera/chip.h b/src/drivers/intel/mipi_camera/chip.h index d133f7d..3ad19c0 100644 --- a/src/drivers/intel/mipi_camera/chip.h +++ b/src/drivers/intel/mipi_camera/chip.h @@ -3,6 +3,7 @@ #ifndef __INTEL_MIPI_CAMERA_CHIP_H__ #define __INTEL_MIPI_CAMERA_CHIP_H__
+#include <stdbool.h> #include <stdint.h> #include <acpi/acpi_pld.h>
diff --git a/src/drivers/intel/ptt/ptt.c b/src/drivers/intel/ptt/ptt.c index 67ed0ee..d3b956d 100644 --- a/src/drivers/intel/ptt/ptt.c +++ b/src/drivers/intel/ptt/ptt.c @@ -3,6 +3,8 @@ #include <soc/pci_devs.h> #include <device/pci_ops.h> #include <console/console.h> +#include <stdbool.h> +#include <stdint.h>
#include "ptt.h"
diff --git a/src/drivers/intel/ptt/ptt.h b/src/drivers/intel/ptt/ptt.h index b447d58..236cb69 100644 --- a/src/drivers/intel/ptt/ptt.h +++ b/src/drivers/intel/ptt/ptt.h @@ -14,4 +14,7 @@ * Checks if the Intel PTT is active. If PTT is active, returns true, * false otherwise. */ + +#include <stdbool.h> + bool ptt_active(void); diff --git a/src/drivers/ipmi/chip.h b/src/drivers/ipmi/chip.h index f561bcd..81befe8 100644 --- a/src/drivers/ipmi/chip.h +++ b/src/drivers/ipmi/chip.h @@ -3,6 +3,9 @@ #ifndef _IMPI_CHIP_H_ #define _IPMI_CHIP_H_
+#include <stdbool.h> +#include <stdint.h> + struct drivers_ipmi_config { u8 bmc_i2c_address; u8 have_nv_storage; diff --git a/src/drivers/lenovo/hybrid_graphics/hybrid_graphics.h b/src/drivers/lenovo/hybrid_graphics/hybrid_graphics.h index b5de8a8..d694865 100644 --- a/src/drivers/lenovo/hybrid_graphics/hybrid_graphics.h +++ b/src/drivers/lenovo/hybrid_graphics/hybrid_graphics.h @@ -3,6 +3,8 @@ #ifndef _DRIVERS_LENOVO_HYBRID_GRAPHICS_H_ #define _DRIVERS_LENOVO_HYBRID_GRAPHICS_H_
+#include <stdbool.h> + void early_hybrid_graphics(bool *enable_igd, bool *enable_peg);
#endif /* _DRIVERS_LENOVO_HYBRID_GRAPHICS_CHIP_H_ */ diff --git a/src/drivers/mrc_cache/mrc_cache.c b/src/drivers/mrc_cache/mrc_cache.c index d567a20..4584855 100644 --- a/src/drivers/mrc_cache/mrc_cache.c +++ b/src/drivers/mrc_cache/mrc_cache.c @@ -12,6 +12,7 @@ #include <region_file.h> #include <security/vboot/vboot_common.h> #include <spi_flash.h> +#include <types.h>
#include "mrc_cache.h"
diff --git a/src/drivers/net/chip.h b/src/drivers/net/chip.h index 9b6a4e5..29936d2 100644 --- a/src/drivers/net/chip.h +++ b/src/drivers/net/chip.h @@ -3,6 +3,7 @@ #ifndef __DRIVERS_R8168_CHIP_H__ #define __DRIVERS_R8168_CHIP_H__
+#include <stdbool.h> #include <stdint.h> #include <acpi/acpi_device.h>
diff --git a/src/drivers/ocp/dmi/smbios.c b/src/drivers/ocp/dmi/smbios.c index 4e54af0..b691eea 100644 --- a/src/drivers/ocp/dmi/smbios.c +++ b/src/drivers/ocp/dmi/smbios.c @@ -11,6 +11,7 @@ #include <soc/soc_util.h> #include <soc/cpu.h> #include <smbios.h> +#include <types.h>
#include "ocp_dmi.h"
diff --git a/src/drivers/spi/acpi/acpi.c b/src/drivers/spi/acpi/acpi.c index c0e776e..39784fe 100644 --- a/src/drivers/spi/acpi/acpi.c +++ b/src/drivers/spi/acpi/acpi.c @@ -7,7 +7,9 @@ #include <device/path.h> #include <device/spi.h> #include <spi-generic.h> +#include <stdbool.h> #include <string.h> + #include "chip.h"
static int spi_acpi_get_bus(const struct device *dev) diff --git a/src/drivers/spi/acpi/chip.h b/src/drivers/spi/acpi/chip.h index 9849f17..3ea3827 100644 --- a/src/drivers/spi/acpi/chip.h +++ b/src/drivers/spi/acpi/chip.h @@ -3,6 +3,7 @@ #ifndef __SPI_ACPI_CHIP_H__ #define __SPI_ACPI_CHIP_H__
+#include <stdbool.h> #include <acpi/acpi_device.h>
struct drivers_spi_acpi_config { diff --git a/src/drivers/spi/boot_device_rw_nommap.c b/src/drivers/spi/boot_device_rw_nommap.c index 58efc87..9352f22 100644 --- a/src/drivers/spi/boot_device_rw_nommap.c +++ b/src/drivers/spi/boot_device_rw_nommap.c @@ -3,7 +3,7 @@ #include <boot_device.h> #include <spi_flash.h> #include <spi-generic.h> -#include <stdint.h> +#include <types.h>
static struct spi_flash sfg; static bool sfg_init_done; diff --git a/src/drivers/spi/cbfs_spi.c b/src/drivers/spi/cbfs_spi.c index 0034460..6248129 100644 --- a/src/drivers/spi/cbfs_spi.c +++ b/src/drivers/spi/cbfs_spi.c @@ -11,8 +11,8 @@ #include <spi_flash.h> #include <symbols.h> #include <cbmem.h> -#include <stdint.h> #include <timer.h> +#include <types.h>
static struct spi_flash spi_flash_info; static bool spi_flash_init_done; diff --git a/src/drivers/spi/spi-generic.c b/src/drivers/spi/spi-generic.c index 597a22d..9ee231d 100644 --- a/src/drivers/spi/spi-generic.c +++ b/src/drivers/spi/spi-generic.c @@ -3,6 +3,7 @@ #include <assert.h> #include <commonlib/helpers.h> #include <spi-generic.h> +#include <stdbool.h> #include <stddef.h> #include <string.h>
diff --git a/src/drivers/spi/winbond.c b/src/drivers/spi/winbond.c index e4151de..59377bd 100644 --- a/src/drivers/spi/winbond.c +++ b/src/drivers/spi/winbond.c @@ -6,6 +6,7 @@ #include <spi-generic.h> #include <delay.h> #include <lib.h> +#include <types.h>
#include "spi_flash_internal.h" #include "spi_winbond.h" diff --git a/src/drivers/uart/acpi/acpi.c b/src/drivers/uart/acpi/acpi.c index f9d9d8f..268ff35 100644 --- a/src/drivers/uart/acpi/acpi.c +++ b/src/drivers/uart/acpi/acpi.c @@ -4,6 +4,7 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/path.h> +#include <stdbool.h> #include <string.h> #include "chip.h"
diff --git a/src/drivers/uart/acpi/chip.h b/src/drivers/uart/acpi/chip.h index 0311165..d5a3cf3 100644 --- a/src/drivers/uart/acpi/chip.h +++ b/src/drivers/uart/acpi/chip.h @@ -4,6 +4,7 @@ #define __DRIVERS_UART_ACPI_H__
#include <acpi/acpi_device.h> +#include <stdbool.h>
struct drivers_uart_acpi_config { const char *hid; /* ACPI _HID (required) */ diff --git a/src/drivers/usb/acpi/chip.h b/src/drivers/usb/acpi/chip.h index 8cd9268..508dde5 100644 --- a/src/drivers/usb/acpi/chip.h +++ b/src/drivers/usb/acpi/chip.h @@ -6,6 +6,7 @@ #include <acpi/acpi_device.h> #include <acpi/acpi.h> #include <acpi/acpi_pld.h> +#include <stdbool.h>
struct drivers_usb_acpi_config { const char *desc; diff --git a/src/drivers/usb/acpi/usb_acpi.c b/src/drivers/usb/acpi/usb_acpi.c index d33b7de..bf6b5d0 100644 --- a/src/drivers/usb/acpi/usb_acpi.c +++ b/src/drivers/usb/acpi/usb_acpi.c @@ -6,6 +6,8 @@ #include <console/console.h> #include <device/device.h> #include <device/path.h> +#include <stdbool.h> + #include "chip.h"
static bool usb_acpi_add_gpios_to_crs(struct drivers_usb_acpi_config *cfg) diff --git a/src/drivers/usb/ehci_debug.c b/src/drivers/usb/ehci_debug.c index 5998172..ba7d761 100644 --- a/src/drivers/usb/ehci_debug.c +++ b/src/drivers/usb/ehci_debug.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <stdint.h> #include <console/console.h> #include <console/usb.h> #include <arch/io.h> @@ -8,6 +7,7 @@ #include <arch/symbols.h> #include <string.h> #include <cbmem.h> +#include <types.h>
#include "ehci_debug.h" #include "usb_ch9.h" diff --git a/src/drivers/usb/pci_xhci/pci_xhci.c b/src/drivers/usb/pci_xhci/pci_xhci.c index a375f07..ed6ccb3 100644 --- a/src/drivers/usb/pci_xhci/pci_xhci.c +++ b/src/drivers/usb/pci_xhci/pci_xhci.c @@ -7,6 +7,7 @@ #include <device/pci_ids.h> #include <device/xhci.h> #include <stdlib.h> +#include <types.h>
#define PCI_XHCI_CLASSCODE 0x0c0330 /* USB3.0 xHCI controller */
diff --git a/src/drivers/vpd/vpd.c b/src/drivers/vpd/vpd.c index c332a6e..079eb46 100644 --- a/src/drivers/vpd/vpd.c +++ b/src/drivers/vpd/vpd.c @@ -7,6 +7,7 @@ #include <program_loading.h> #include <string.h> #include <timestamp.h> +#include <types.h>
#include "vpd.h" #include "vpd_decode.h"
Hello build bot (Jenkins), Lee Leahy, Huang Jin, Andrey Petrov, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43967
to look at the new patch set (#2).
Change subject: src/drivers: Add missing '#include <{stdbool,stddef,stdint}.h>' ......................................................................
src/drivers: Add missing '#include <{stdbool,stddef,stdint}.h>'
Include <types.h> when stddef, stdint and stdbool are needed.
Change-Id: Ic251fe12777f03c4a14dd707be66f6e9223cd7df Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/aspeed/common/ast_dp501.c M src/drivers/aspeed/common/ast_drv.h M src/drivers/aspeed/common/ast_main.c M src/drivers/aspeed/common/ast_mode.c M src/drivers/aspeed/common/ast_mode_corebootfb.c M src/drivers/aspeed/common/ast_post.c M src/drivers/elog/elog.c M src/drivers/generic/gpio_keys/chip.h M src/drivers/i2c/generic/chip.h M src/drivers/i2c/generic/generic.c M src/drivers/i2c/max98373/chip.h M src/drivers/i2c/max98927/chip.h M src/drivers/intel/dptf/chip.h M src/drivers/intel/dptf/dptf.c M src/drivers/intel/fsp1_1/hob.c M src/drivers/intel/fsp1_1/include/fsp/romstage.h M src/drivers/intel/fsp1_1/raminit.c M src/drivers/intel/fsp1_1/romstage.c M src/drivers/intel/fsp2_0/hand_off_block.c M src/drivers/intel/fsp2_0/include/fsp/api.h M src/drivers/intel/mipi_camera/chip.h M src/drivers/intel/ptt/ptt.c M src/drivers/intel/ptt/ptt.h M src/drivers/ipmi/chip.h M src/drivers/lenovo/hybrid_graphics/hybrid_graphics.h M src/drivers/mrc_cache/mrc_cache.c M src/drivers/net/chip.h M src/drivers/ocp/dmi/smbios.c M src/drivers/spi/acpi/acpi.c M src/drivers/spi/acpi/chip.h M src/drivers/spi/boot_device_rw_nommap.c M src/drivers/spi/cbfs_spi.c M src/drivers/spi/spi-generic.c M src/drivers/spi/winbond.c M src/drivers/uart/acpi/acpi.c M src/drivers/uart/acpi/chip.h M src/drivers/usb/acpi/chip.h M src/drivers/usb/acpi/usb_acpi.c M src/drivers/usb/ehci_debug.c M src/drivers/usb/pci_xhci/pci_xhci.c M src/drivers/vpd/vpd.c 41 files changed, 63 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/43967/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43967 )
Change subject: src/drivers: Add missing '#include <{stdbool,stddef,stdint}.h>' ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43967/2/src/drivers/intel/fsp2_0/in... File src/drivers/intel/fsp2_0/include/fsp/api.h:
https://review.coreboot.org/c/coreboot/+/43967/2/src/drivers/intel/fsp2_0/in... PS2, Line 10: <stdbool.h> use of <types.h> will give an error: https://qa.coreboot.org/job/coreboot-gerrit/136626/testReport/junit/(root)/b...
Hello build bot (Jenkins), Lee Leahy, Julius Werner, Huang Jin, Andrey Petrov, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43967
to look at the new patch set (#3).
Change subject: src/drivers: Add missing '#include <{stdbool,stddef,stdint}.h>' ......................................................................
src/drivers: Add missing '#include <{stdbool,stddef,stdint}.h>'
Include <types.h> when stddef, stdint and stdbool are needed.
Change-Id: Ic251fe12777f03c4a14dd707be66f6e9223cd7df Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/aspeed/common/ast_dp501.c M src/drivers/aspeed/common/ast_drv.h M src/drivers/aspeed/common/ast_main.c M src/drivers/aspeed/common/ast_mode.c M src/drivers/aspeed/common/ast_mode_corebootfb.c M src/drivers/aspeed/common/ast_post.c M src/drivers/elog/elog.c M src/drivers/generic/gpio_keys/chip.h M src/drivers/i2c/generic/chip.h M src/drivers/i2c/generic/generic.c M src/drivers/i2c/max98373/chip.h M src/drivers/i2c/max98927/chip.h M src/drivers/intel/dptf/chip.h M src/drivers/intel/dptf/dptf.c M src/drivers/intel/fsp1_1/hob.c M src/drivers/intel/fsp1_1/include/fsp/romstage.h M src/drivers/intel/fsp1_1/raminit.c M src/drivers/intel/fsp1_1/romstage.c M src/drivers/intel/fsp2_0/hand_off_block.c M src/drivers/intel/fsp2_0/include/fsp/api.h M src/drivers/intel/mipi_camera/chip.h M src/drivers/intel/ptt/ptt.c M src/drivers/intel/ptt/ptt.h M src/drivers/ipmi/chip.h M src/drivers/lenovo/hybrid_graphics/hybrid_graphics.h M src/drivers/mrc_cache/mrc_cache.c M src/drivers/net/chip.h M src/drivers/ocp/dmi/smbios.c M src/drivers/spi/acpi/acpi.c M src/drivers/spi/acpi/chip.h M src/drivers/spi/boot_device_rw_nommap.c M src/drivers/spi/cbfs_spi.c M src/drivers/spi/spi-generic.c M src/drivers/spi/winbond.c M src/drivers/uart/acpi/acpi.c M src/drivers/uart/acpi/chip.h M src/drivers/usb/acpi/chip.h M src/drivers/usb/acpi/usb_acpi.c M src/drivers/usb/ehci_debug.c M src/drivers/usb/pci_xhci/pci_xhci.c M src/drivers/vpd/vpd.c 41 files changed, 63 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/43967/3
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43967 )
Change subject: src/drivers: Add missing '#include <{stdbool,stddef,stdint}.h>' ......................................................................
Patch Set 3:
This is a problem with Intel FSP. Replace the #include <stddef.h> in src/drivers/intel/fsp2_0/include/fsp/soc_binding.h with #include <types.h> and I think that should fix it.
Hello build bot (Jenkins), Lee Leahy, Julius Werner, Huang Jin, Andrey Petrov, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43967
to look at the new patch set (#4).
Change subject: src/drivers: Add missing '#include <{stdbool,stddef,stdint}.h>' ......................................................................
src/drivers: Add missing '#include <{stdbool,stddef,stdint}.h>'
Include <types.h> when stddef, stdint and stdbool are needed.
Change-Id: Ic251fe12777f03c4a14dd707be66f6e9223cd7df Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/aspeed/common/ast_dp501.c M src/drivers/aspeed/common/ast_drv.h M src/drivers/aspeed/common/ast_main.c M src/drivers/aspeed/common/ast_mode.c M src/drivers/aspeed/common/ast_mode_corebootfb.c M src/drivers/aspeed/common/ast_post.c M src/drivers/elog/elog.c M src/drivers/generic/gpio_keys/chip.h M src/drivers/i2c/generic/chip.h M src/drivers/i2c/generic/generic.c M src/drivers/i2c/max98373/chip.h M src/drivers/i2c/max98927/chip.h M src/drivers/intel/dptf/chip.h M src/drivers/intel/dptf/dptf.c M src/drivers/intel/fsp1_1/hob.c M src/drivers/intel/fsp1_1/include/fsp/romstage.h M src/drivers/intel/fsp1_1/raminit.c M src/drivers/intel/fsp1_1/romstage.c M src/drivers/intel/fsp2_0/hand_off_block.c M src/drivers/intel/fsp2_0/include/fsp/api.h M src/drivers/intel/fsp2_0/include/fsp/soc_binding.h M src/drivers/intel/mipi_camera/chip.h M src/drivers/intel/ptt/ptt.c M src/drivers/intel/ptt/ptt.h M src/drivers/ipmi/chip.h M src/drivers/lenovo/hybrid_graphics/hybrid_graphics.h M src/drivers/mrc_cache/mrc_cache.c M src/drivers/net/chip.h M src/drivers/ocp/dmi/smbios.c M src/drivers/spi/acpi/acpi.c M src/drivers/spi/acpi/chip.h M src/drivers/spi/boot_device_rw_nommap.c M src/drivers/spi/cbfs_spi.c M src/drivers/spi/spi-generic.c M src/drivers/spi/winbond.c M src/drivers/uart/acpi/acpi.c M src/drivers/uart/acpi/chip.h M src/drivers/usb/acpi/chip.h M src/drivers/usb/acpi/usb_acpi.c M src/drivers/usb/ehci_debug.c M src/drivers/usb/pci_xhci/pci_xhci.c M src/drivers/vpd/vpd.c 42 files changed, 64 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/43967/4
Hello build bot (Jenkins), Lee Leahy, Julius Werner, Huang Jin, Andrey Petrov, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43967
to look at the new patch set (#5).
Change subject: src/drivers: Add missing '#include <{stdbool,stddef,stdint}.h>' ......................................................................
src/drivers: Add missing '#include <{stdbool,stddef,stdint}.h>'
Include <types.h> when stddef, stdint and stdbool are needed.
Change-Id: Ic251fe12777f03c4a14dd707be66f6e9223cd7df Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/aspeed/common/ast_dp501.c M src/drivers/aspeed/common/ast_drv.h M src/drivers/aspeed/common/ast_main.c M src/drivers/aspeed/common/ast_mode.c M src/drivers/aspeed/common/ast_mode_corebootfb.c M src/drivers/aspeed/common/ast_post.c M src/drivers/elog/elog.c M src/drivers/generic/gpio_keys/chip.h M src/drivers/i2c/generic/chip.h M src/drivers/i2c/generic/generic.c M src/drivers/i2c/max98373/chip.h M src/drivers/i2c/max98927/chip.h M src/drivers/intel/dptf/chip.h M src/drivers/intel/dptf/dptf.c M src/drivers/intel/fsp1_1/hob.c M src/drivers/intel/fsp1_1/include/fsp/romstage.h M src/drivers/intel/fsp1_1/raminit.c M src/drivers/intel/fsp1_1/romstage.c M src/drivers/intel/fsp2_0/hand_off_block.c M src/drivers/intel/fsp2_0/include/fsp/api.h M src/drivers/intel/fsp2_0/include/fsp/soc_binding.h M src/drivers/intel/mipi_camera/chip.h M src/drivers/intel/ptt/ptt.c M src/drivers/intel/ptt/ptt.h M src/drivers/ipmi/chip.h M src/drivers/lenovo/hybrid_graphics/hybrid_graphics.h M src/drivers/mrc_cache/mrc_cache.c M src/drivers/net/chip.h M src/drivers/ocp/dmi/smbios.c M src/drivers/spi/acpi/acpi.c M src/drivers/spi/acpi/chip.h M src/drivers/spi/boot_device_rw_nommap.c M src/drivers/spi/cbfs_spi.c M src/drivers/spi/spi-generic.c M src/drivers/spi/winbond.c M src/drivers/uart/acpi/acpi.c M src/drivers/uart/acpi/chip.h M src/drivers/usb/acpi/chip.h M src/drivers/usb/acpi/usb_acpi.c M src/drivers/usb/ehci_debug.c M src/drivers/usb/pci_xhci/pci_xhci.c M src/drivers/vpd/vpd.c 42 files changed, 64 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/43967/5
Hello build bot (Jenkins), Lee Leahy, Julius Werner, Huang Jin, Andrey Petrov, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43967
to look at the new patch set (#6).
Change subject: src/drivers: Add missing '#include <{stdbool,stddef,stdint}.h>' ......................................................................
src/drivers: Add missing '#include <{stdbool,stddef,stdint}.h>'
Include <types.h> when stddef, stdint and stdbool are needed.
Change-Id: Ic251fe12777f03c4a14dd707be66f6e9223cd7df Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/aspeed/common/ast_dp501.c M src/drivers/aspeed/common/ast_drv.h M src/drivers/aspeed/common/ast_main.c M src/drivers/aspeed/common/ast_mode.c M src/drivers/aspeed/common/ast_mode_corebootfb.c M src/drivers/aspeed/common/ast_post.c M src/drivers/elog/elog.c M src/drivers/generic/gpio_keys/chip.h M src/drivers/i2c/generic/chip.h M src/drivers/i2c/generic/generic.c M src/drivers/i2c/max98373/chip.h M src/drivers/i2c/max98927/chip.h M src/drivers/intel/dptf/chip.h M src/drivers/intel/dptf/dptf.c M src/drivers/intel/fsp1_1/hob.c M src/drivers/intel/fsp1_1/include/fsp/romstage.h M src/drivers/intel/fsp1_1/raminit.c M src/drivers/intel/fsp1_1/romstage.c M src/drivers/intel/fsp2_0/hand_off_block.c M src/drivers/intel/fsp2_0/include/fsp/api.h M src/drivers/intel/fsp2_0/include/fsp/soc_binding.h M src/drivers/intel/mipi_camera/chip.h M src/drivers/intel/ptt/ptt.c M src/drivers/intel/ptt/ptt.h M src/drivers/ipmi/chip.h M src/drivers/lenovo/hybrid_graphics/hybrid_graphics.h M src/drivers/mrc_cache/mrc_cache.c M src/drivers/net/chip.h M src/drivers/ocp/dmi/smbios.c M src/drivers/spi/acpi/acpi.c M src/drivers/spi/acpi/chip.h M src/drivers/spi/boot_device_rw_nommap.c M src/drivers/spi/cbfs_spi.c M src/drivers/spi/spi-generic.c M src/drivers/spi/winbond.c M src/drivers/uart/acpi/acpi.c M src/drivers/uart/acpi/chip.h M src/drivers/usb/acpi/chip.h M src/drivers/usb/acpi/usb_acpi.c M src/drivers/usb/ehci_debug.c M src/drivers/usb/pci_xhci/pci_xhci.c M src/drivers/vpd/vpd.c 42 files changed, 64 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/43967/6
Hello build bot (Jenkins), Lee Leahy, Julius Werner, Huang Jin, Andrey Petrov, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43967
to look at the new patch set (#8).
Change subject: src/drivers: Add missing '#include <{stdbool,stddef,stdint}.h>' ......................................................................
src/drivers: Add missing '#include <{stdbool,stddef,stdint}.h>'
Include <types.h> when stddef, stdint and stdbool are needed. Also, remove useless comment.
Change-Id: Ic251fe12777f03c4a14dd707be66f6e9223cd7df Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/aspeed/common/ast_dp501.c M src/drivers/aspeed/common/ast_drv.h M src/drivers/aspeed/common/ast_main.c M src/drivers/aspeed/common/ast_mode.c M src/drivers/aspeed/common/ast_mode_corebootfb.c M src/drivers/aspeed/common/ast_post.c M src/drivers/elog/elog.c M src/drivers/generic/gpio_keys/chip.h M src/drivers/i2c/generic/chip.h M src/drivers/i2c/generic/generic.c M src/drivers/i2c/max98373/chip.h M src/drivers/i2c/max98927/chip.h M src/drivers/intel/dptf/chip.h M src/drivers/intel/dptf/dptf.c M src/drivers/intel/fsp1_1/hob.c M src/drivers/intel/fsp1_1/include/fsp/romstage.h M src/drivers/intel/fsp1_1/raminit.c M src/drivers/intel/fsp1_1/romstage.c M src/drivers/intel/fsp2_0/hand_off_block.c M src/drivers/intel/fsp2_0/include/fsp/api.h M src/drivers/intel/fsp2_0/include/fsp/soc_binding.h M src/drivers/intel/mipi_camera/chip.h M src/drivers/intel/ptt/ptt.c M src/drivers/intel/ptt/ptt.h M src/drivers/ipmi/chip.h M src/drivers/lenovo/hybrid_graphics/hybrid_graphics.h M src/drivers/mrc_cache/mrc_cache.c M src/drivers/net/chip.h M src/drivers/ocp/dmi/smbios.c M src/drivers/spi/acpi/acpi.c M src/drivers/spi/acpi/chip.h M src/drivers/spi/boot_device_rw_nommap.c M src/drivers/spi/cbfs_spi.c M src/drivers/spi/spi-generic.c M src/drivers/spi/winbond.c M src/drivers/uart/acpi/acpi.c M src/drivers/uart/acpi/chip.h M src/drivers/usb/acpi/chip.h M src/drivers/usb/acpi/usb_acpi.c M src/drivers/usb/ehci_debug.c M src/drivers/usb/pci_xhci/pci_xhci.c M src/drivers/vpd/vpd.c 42 files changed, 59 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/43967/8
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43967 )
Change subject: src/drivers: Add missing '#include <{stdbool,stddef,stdint}.h>' ......................................................................
Abandoned
-
HAOUAS Elyes (Code Review) -
Julius Werner (Code Review)