HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33436
Change subject: sb/nvidia/ck804/fadt.c: Remove unused LONG_FADT ......................................................................
sb/nvidia/ck804/fadt.c: Remove unused LONG_FADT
LONG_FADT is not used at all. So remove it and use sizeof(acpi_fadt_t) for header length.
Change-Id: I433d1b2e0f3b9505d7c52eb14f1a476fbe52a284 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/nvidia/ck804/fadt.c 1 file changed, 1 insertion(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/33436/1
diff --git a/src/southbridge/nvidia/ck804/fadt.c b/src/southbridge/nvidia/ck804/fadt.c index f6ad479..713a51e 100644 --- a/src/southbridge/nvidia/ck804/fadt.c +++ b/src/southbridge/nvidia/ck804/fadt.c @@ -33,13 +33,8 @@ /* Prepare the header */ memset((void *)fadt, 0, sizeof(acpi_fadt_t)); memcpy(header->signature, "FACP", 4); -#ifdef LONG_FADT - header->length = 244; + header->length = sizeof(acpi_fadt_t); header->revision = get_acpi_table_revision(FADT); -#else - header->length = 0x74; - header->revision = 1; -#endif memcpy(header->oem_id, OEM_ID, 6); memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8); memcpy(header->asl_compiler_id, ASLC, 4);
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33436 )
Change subject: sb/nvidia/ck804/fadt.c: Remove unused LONG_FADT ......................................................................
Patch Set 1: Code-Review+1
Looks good, the symbol is dead since it was introduced according to grep
Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33436 )
Change subject: sb/nvidia/ck804/fadt.c: Remove unused LONG_FADT ......................................................................
Patch Set 1: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33436 )
Change subject: sb/nvidia/ck804/fadt.c: Remove unused LONG_FADT ......................................................................
sb/nvidia/ck804/fadt.c: Remove unused LONG_FADT
LONG_FADT is not used at all. So remove it and use sizeof(acpi_fadt_t) for header length.
Change-Id: I433d1b2e0f3b9505d7c52eb14f1a476fbe52a284 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/33436 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Lance Zhao lance.zhao@gmail.com --- M src/southbridge/nvidia/ck804/fadt.c 1 file changed, 1 insertion(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Lance Zhao: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve
diff --git a/src/southbridge/nvidia/ck804/fadt.c b/src/southbridge/nvidia/ck804/fadt.c index f6ad479..713a51e 100644 --- a/src/southbridge/nvidia/ck804/fadt.c +++ b/src/southbridge/nvidia/ck804/fadt.c @@ -33,13 +33,8 @@ /* Prepare the header */ memset((void *)fadt, 0, sizeof(acpi_fadt_t)); memcpy(header->signature, "FACP", 4); -#ifdef LONG_FADT - header->length = 244; + header->length = sizeof(acpi_fadt_t); header->revision = get_acpi_table_revision(FADT); -#else - header->length = 0x74; - header->revision = 1; -#endif memcpy(header->oem_id, OEM_ID, 6); memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8); memcpy(header->asl_compiler_id, ASLC, 4);
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Lance Zhao (Code Review)
-
Martin Roth (Code Review)