Attention is currently required from: Bhanu Prakash Maiya, Kenneth Chan, Karthik Ramasubramanian. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60442 )
Change subject: mb/google/guybrush/var/dewatt: Update for RT1019 amp dev id was changed ......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60442/comment/21562708_58c51593 PS4, Line 11: 1019 id changed to 10EC1019:0/10EC1019:1 from 10EC1019:1/10EC1019:2.
Original code is referring to guybrush , using I2C 0x28, 0x29, 0x2a for 1019. […]
OK. Should uid="0" for 0x28 and uid="1" for 0x29?
File src/mainboard/google/guybrush/variants/dewatt/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/60442/comment/9e404241_0ba191d6 PS4, Line 151: register "uid" = "1"
I refer to guybrush CRB codes, 0x29 w/o probed=1 and 0x2a with probed=1
Looks like the probed parameter was added in https://review.coreboot.org/c/coreboot/+/55028/3/src/mainboard/google/guybru.... I think probed is only required for peripherals that may not exist on the board. For dewatt these peripherals will always exist (right?), so we can remove probed from 0x2a as well.