build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52887 )
Change subject: mb/google/dedede/var/metaknight: Update xhci device tree ......................................................................
Patch Set 1:
(36 comments)
File src/mainboard/google/dedede/variants/metaknight/variant.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/1a148020_3daa54b4 PS1, Line 20: const struct device *xhci, *hub = NULL, *port = NULL; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/476fd066_4fe8bed0 PS1, Line 20: const struct device *xhci, *hub = NULL, *port = NULL; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/0bee93f5_832f862d PS1, Line 21: const struct drivers_usb_acpi_config *config; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/3be55640_7cbb1cd3 PS1, Line 21: const struct drivers_usb_acpi_config *config; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/9b1be74b_2f657b91 PS1, Line 23: xhci = pcidev_path_on_root(PCH_DEVFN_XHCI); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/d35c9204_d42b0eb3 PS1, Line 23: xhci = pcidev_path_on_root(PCH_DEVFN_XHCI); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/ce5a3b49_79938b24 PS1, Line 24: if (!xhci) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/27835926_b99cd138 PS1, Line 24: if (!xhci) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/f9e12fb4_90736ada PS1, Line 25: printk(BIOS_ERR, "%s: Could not locate XHCI device in DT\n", __func__); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/4d6ecfbe_1c8f3667 PS1, Line 25: printk(BIOS_ERR, "%s: Could not locate XHCI device in DT\n", __func__); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/b3ef0403_786058f6 PS1, Line 26: return; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/d28ce786_e7337ad7 PS1, Line 26: return; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/3f1d1cb9_36110afa PS1, Line 27: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/019b058c_ff4bec95 PS1, Line 27: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/7b6483e0_b8ad4d54 PS1, Line 29: while ((hub = dev_bus_each_child(xhci->link_list, hub)) != NULL) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/686a55a5_00ac03dd PS1, Line 29: while ((hub = dev_bus_each_child(xhci->link_list, hub)) != NULL) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/b9847bc9_66c921d3 PS1, Line 30: while ((port = dev_bus_each_child(hub->link_list, port)) != NULL) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/67598ca9_6f56b333 PS1, Line 30: while ((port = dev_bus_each_child(hub->link_list, port)) != NULL) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/c11cb842_7dc2007b PS1, Line 31: if ((port->path.usb.port_id != 3)) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/6e0c0b5d_17cbc625 PS1, Line 31: if ((port->path.usb.port_id != 3)) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/f708ffe7_a83fa185 PS1, Line 32: continue; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/e25d7bea_802fed14 PS1, Line 32: continue; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/dc958c41_45a394af PS1, Line 34: config = config_of(port); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/189957f3_297fb9e8 PS1, Line 34: config = config_of(port); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/8feeff47_403c0f36 PS1, Line 35: if (fw_config_probe(FW_CONFIG(DB_PORTS, DB_PORTS_1A_HDMI))) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/d82611de_ae93584c PS1, Line 35: if (fw_config_probe(FW_CONFIG(DB_PORTS, DB_PORTS_1A_HDMI))) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/bc963f1e_7b8c5db2 PS1, Line 36: /* Set 1A HDMI configuration */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/3bf4bd58_1ef41c18 PS1, Line 37: } else if (fw_config_probe(FW_CONFIG(DB_PORTS, DB_PORTS_LTE_HDMI))) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/6e9e4529_045a4553 PS1, Line 37: } else if (fw_config_probe(FW_CONFIG(DB_PORTS, DB_PORTS_LTE_HDMI))) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/9664b489_e1dcf43b PS1, Line 38: /* Set LTE HDMI configuration */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/787bcdfa_b07767af PS1, Line 39: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/1b0a5ed6_ae47fc04 PS1, Line 39: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/7fe4b271_9ba91c9a PS1, Line 40: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/0b2ddaad_3e0ec0a7 PS1, Line 40: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/c05cb113_3f944942 PS1, Line 41: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118390): https://review.coreboot.org/c/coreboot/+/52887/comment/1be89be1_d12d13d5 PS1, Line 41: } please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)