Barnali Sarkar has posted comments on this change. ( https://review.coreboot.org/18557 )
Change subject: soc/intel/common/block: [WIP]Add Intel common FAST_SPI code ......................................................................
Patch Set 17:
(4 comments)
https://review.coreboot.org/#/c/18557/17/src/soc/intel/common/block/fast_spi... File src/soc/intel/common/block/fast_spi/fast_spi.c:
Line 22:
can we have some /*TODO*/ so that next time, when we create flash_ctrl.c as
okay
PS17, Line 155: device_t dev
can't we use device_t as local here after we have common pci_dev name?
yes sure, will fix it.
https://review.coreboot.org/#/c/18557/17/src/soc/intel/common/block/include/... File src/soc/intel/common/block/include/intelblocks/fast_spi.h:
PS17, Line 4: Copyright 2017 Intel Corporation.
please adhere comments from Summet, missing (C)
ok
https://review.coreboot.org/#/c/18557/17/src/soc/intel/common/block/include/... File src/soc/intel/common/block/include/intelblocks/fast_spi_def.h:
PS17, Line 4: * Copyright 2017 Intel Corporation.
-same
ok
-
Barnali Sarkar (Code Review)