Attention is currently required from: Hung-Te Lin, Paul Menzel, Ruihai Zhou.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78954?usp=email )
Change subject: mb/google/geralt: Create variant Ciri
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78954/comment/3e72347f_b2c246d7 :
PS2, Line 9: and enable MAX98390 AMP for it.
If you can be more specific, please do it. […]
Paul, I appreciate your work making sure that coreboot has good commit messages. I think it's greatly improved the project, so I'm not making an overall objection, but in this case, I don't think the change is needed. It's in the geralt mainboard directory, it's creating a variant. Requiring the commit message to say that it's a copy is completely unnecessary. I mean, this commit isn't even creating anything - it's just adding the name to the existing Kconfig files.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78954?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7bbe9ed5e722a70bab1c799a61ce38d2ad58ab25
Gerrit-Change-Number: 78954
Gerrit-PatchSet: 4
Gerrit-Owner: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cong yang
yangcong5@huaqin.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Wed, 15 Nov 2023 20:28:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-MessageType: comment