Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40777 )
Change subject: soc/amd/common/block/sata: Add missing .ops_pci member ......................................................................
soc/amd/common/block/sata: Add missing .ops_pci member
This change sets .ops_pci for sata device_operations to default pci_dev_ops_pci.
BUG=b:153858769
Change-Id: I695ac8961c92a3061beca890f5d47413b251e22b Signed-off-by: Furquan Shaikh furquan@google.com --- M src/soc/amd/common/block/sata/sata.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/40777/1
diff --git a/src/soc/amd/common/block/sata/sata.c b/src/soc/amd/common/block/sata/sata.c index 4db00b1..1959d3d 100644 --- a/src/soc/amd/common/block/sata/sata.c +++ b/src/soc/amd/common/block/sata/sata.c @@ -19,6 +19,7 @@ .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, .init = soc_enable_sata_features, + .ops_pci = &pci_dev_ops_pci, .acpi_name = sata_acpi_name, .acpi_fill_ssdt = acpi_device_write_pci_dev, };
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40777 )
Change subject: soc/amd/common/block/sata: Add missing .ops_pci member ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40777/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40777/1//COMMIT_MSG@11 PS1, Line 11: What does this fix?
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40777 )
Change subject: soc/amd/common/block/sata: Add missing .ops_pci member ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40777/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40777/1//COMMIT_MSG@11 PS1, Line 11:
What does this fix?
It helps assigning subsystem IDs. It makes it consistent with what the default pci_ops do. I will add the motivation to commit message.
Hello build bot (Jenkins), Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40777
to look at the new patch set (#2).
Change subject: soc/amd/common/block/sata: Add missing .ops_pci member ......................................................................
soc/amd/common/block/sata: Add missing .ops_pci member
This change sets .ops_pci for sata device_operations to default pci_dev_ops_pci. It is required to set the subsystem IDs making the behavior consistent with default_pci_ops_dev.
BUG=b:153858769
Change-Id: I695ac8961c92a3061beca890f5d47413b251e22b Signed-off-by: Furquan Shaikh furquan@google.com --- M src/soc/amd/common/block/sata/sata.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/40777/2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40777 )
Change subject: soc/amd/common/block/sata: Add missing .ops_pci member ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40777/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40777/1//COMMIT_MSG@11 PS1, Line 11:
It helps assigning subsystem IDs. It makes it consistent with what the default pci_ops do. […]
Done
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40777 )
Change subject: soc/amd/common/block/sata: Add missing .ops_pci member ......................................................................
Patch Set 2: Code-Review+2
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40777 )
Change subject: soc/amd/common/block/sata: Add missing .ops_pci member ......................................................................
Patch Set 2: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40777 )
Change subject: soc/amd/common/block/sata: Add missing .ops_pci member ......................................................................
Patch Set 2: Code-Review+2
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40777 )
Change subject: soc/amd/common/block/sata: Add missing .ops_pci member ......................................................................
soc/amd/common/block/sata: Add missing .ops_pci member
This change sets .ops_pci for sata device_operations to default pci_dev_ops_pci. It is required to set the subsystem IDs making the behavior consistent with default_pci_ops_dev.
BUG=b:153858769
Change-Id: I695ac8961c92a3061beca890f5d47413b251e22b Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40777 Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/common/block/sata/sata.c 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved HAOUAS Elyes: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/soc/amd/common/block/sata/sata.c b/src/soc/amd/common/block/sata/sata.c index 4db00b1..1959d3d 100644 --- a/src/soc/amd/common/block/sata/sata.c +++ b/src/soc/amd/common/block/sata/sata.c @@ -19,6 +19,7 @@ .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, .init = soc_enable_sata_features, + .ops_pci = &pci_dev_ops_pci, .acpi_name = sata_acpi_name, .acpi_fill_ssdt = acpi_device_write_pci_dev, };
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40777 )
Change subject: soc/amd/common/block/sata: Add missing .ops_pci member ......................................................................
Patch Set 3:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2828 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2827 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2826 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/2825
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Aaron Durbin (Code Review)
-
Angel Pons (Code Review)
-
Furquan Shaikh (Code Review)
-
HAOUAS Elyes (Code Review)
-
Paul Menzel (Code Review)