Change in coreboot[master]: mb/google/herobrine: Transition BOARD_HEROBRINE to BOARD_HEROBRINE_REV0
Attention is currently required from: Shelley Chen. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60284 )
Change subject: mb/google/herobrine: Transition BOARD_HEROBRINE to BOARD_HEROBRINE_REV0 ......................................................................
Patch Set 2: Code-Review+2
(2 comments)
File src/mainboard/google/herobrine/Kconfig:
https://review.coreboot.org/c/coreboot/+/60284/comment/ae853852_b390efc7 PS2, Line 50: default "Herobrine_Rev0" if BOARD_GOOGLE_HEROBRINE_REV0 nit: I feel like this should still be "Herobrine" because it is used to construct the FWID, which may be used by certain things (e.g. mosys) to detect the board type. Then again, maybe you want to be able to distinguish these in FWIDs... how about you make it "Herobrine.rev0", because FWIDs are usually split with dots, so this would lead to a full FWID of "Google_Herobrine.rev0.12345.678.0" or something like that, and anything parsing the part up to the first dot would still correctly detect this as a Herobrine.
File src/mainboard/google/herobrine/mainboard.c:
https://review.coreboot.org/c/coreboot/+/60284/comment/ad5b36b2_da64a518 PS2, Line 75: /* BOARD_GOOGLE_HEROBRINE */ nit: This comment is going to be more confusing than helpful once you add more boards.
-
Julius Werner (Code Review)