Attention is currently required from: Michał Żygowski, Paul Menzel, Subrata Banik, Tarun Tuli.
Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76418?usp=email )
Change subject: soc/intel/alderlake: Depend RPL-guarded FSP UPDs on FSP_USE_REPO
......................................................................
Patch Set 6:
(2 comments)
File src/soc/intel/alderlake/include/soc/vr_config.h:
https://review.coreboot.org/c/coreboot/+/76418/comment/432a6791_85f78c71 :
PS5, Line 12: /*
Ah, no.
Thanks.
File src/soc/intel/alderlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/76418/comment/aec5c1a6_eb4e42e9 :
PS6, Line 273: (!CONFIG(SOC_INTEL_ALDERLAKE_PCH_N) && CONFIG(FSP_USE_REPO))
please, no spaces at the start of a line
Please fix.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76418?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5a2da463a74f4ac80dcb407a39fc45b0b6a10a8
Gerrit-Change-Number: 76418
Gerrit-PatchSet: 6
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jan Samek
jan.samek@siemens.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 01 Aug 2023 13:04:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-MessageType: comment