Stefan Reinauer (stefan.reinauer@coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10575
-gerrit
commit a359dc25ea19266e589fea60a5ac8a9b20097b9a Author: Stefan Reinauer stefan.reinauer@coreboot.org Date: Wed Jun 17 16:09:10 2015 -0700
x86: make memcpy 64bit safe
This does not optimize memcpy for 64bit, it merely makes it compile.
Change-Id: I69ad6bd0c3d5f617d9222643abf7a2ba7c2a0359 Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org Signed-off-by: Scott Duplichan scott@notabs.org --- src/arch/x86/lib/memcpy.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/src/arch/x86/lib/memcpy.c b/src/arch/x86/lib/memcpy.c index 7f079ce..4915a9e 100644 --- a/src/arch/x86/lib/memcpy.c +++ b/src/arch/x86/lib/memcpy.c @@ -5,8 +5,13 @@ void *memcpy(void *dest, const void *src, size_t n) unsigned long d0, d1, d2;
asm volatile( +#ifdef __x86_64__ + "rep ; movsd\n\t" + "mov %4,%%rcx\n\t" +#else "rep ; movsl\n\t" "movl %4,%%ecx\n\t" +#endif "rep ; movsb\n\t" : "=&c" (d0), "=&D" (d1), "=&S" (d2) : "0" (n >> 2), "g" (n & 3), "1" (dest), "2" (src)
-
Stefan Reinauer