Attention is currently required from: Raul Rangel, Paul Menzel, Jon Murphy, Karthik Ramasubramanian. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63968 )
Change subject: drivers/usb: Add chip driver for external USB hub ......................................................................
Patch Set 3:
(3 comments)
File src/drivers/usb/ext_hub/Kconfig:
https://review.coreboot.org/c/coreboot/+/63968/comment/85e9dad6_96360612 PS3, Line 1: EXTERNAL
Should we remove the EXTERNAL? The help text says `soldered down`, so it's kind of confusing since i […]
I think he means external to the SoC, it's all relative 😜
File src/drivers/usb/vl/acpi_vl822.c:
https://review.coreboot.org/c/coreboot/+/63968/comment/0ee3ff27_dc22d9e0 PS2, Line 73: /* Device */ the new API (acpigen_write_*_end) makes these comments unnecessary, don't you think?
https://review.coreboot.org/c/coreboot/+/63968/comment/8ae8fa80_afd3e5f2 PS2, Line 74: * Scope */ same
-
Tim Wawrzynczak (Code Review)