Attention is currently required from: Subrata Banik, Michael Niewöhner. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57226 )
Change subject: mb/intel/kblrvp: Disable I2C #4 and #5 on PCH-H ......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/intel/kblrvp/variants/rvp11/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/57226/comment/b4d424c4_ac05e094 PS1, Line 108: device pci 19.2 off end # I2C #4
This needs to be in the overridetree because the devicetree enables it. I didn't want to reshuffle the devicetrees just to save one line.
Sorry, I completely missed that. Maybe add a hint to the commit message? e.g. `The I2C #4 and I2C #5 devices present in the devicetree do not exist on PCH-H. Override the enabled I2C #4 and drop I2C #5.`
Sounds good, will do.
-
Angel Pons (Code Review)