Change in coreboot[master]: sb/intel/i82801gx: Use symbolic name for register, code rework
2 Oct
2019
2 Oct
'19
7:57 a.m.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35737 )
Change subject: sb/intel/i82801gx: Use symbolic name for register, code rework ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/35737/3/src/southbridge/intel/i8280... File src/southbridge/intel/i82801gx/sata.c:
https://review.coreboot.org/c/coreboot/+/35737/3/src/southbridge/intel/i8280... PS3, Line 159: 0xc nit: add comment that this is GHC_PI.
--
To view, visit https://review.coreboot.org/c/coreboot/+/35737
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I33509befe86ff6e333c559c87a0f45886d737df9
Gerrit-Change-Number: 35737
Gerrit-PatchSet: 3
Gerrit-Owner: Petr Cvek petrcvekcz@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Petr Cvek petrcvekcz@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 02 Oct 2019 07:57:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
1882
days inactive
1882
days old
0 comments
1 participants
participants (1)
-
Arthur Heymans (Code Review)