Attention is currently required from: Jason Glenesk, Martin Roth, Marshall Dawson, Angel Pons, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50339 )
Change subject: soc/amd/cezanne: Add root_complex ......................................................................
Patch Set 2:
(3 comments)
File src/soc/amd/cezanne/root_complex.c:
https://review.coreboot.org/c/coreboot/+/50339/comment/cff83acd_7376047f PS1, Line 23: reserved_dram_end
To avoid having so much empty space on the left margin, how about moving this to the right side?
I tried it, but it was a little confusing. The left shows region variables, and the right shows Kconfig constants. I think keeping it this way makes it more clear.
https://review.coreboot.org/c/coreboot/+/50339/comment/e2f097f1_07f8f2db PS1, Line 88: 1MB
nit: MiB
Done
https://review.coreboot.org/c/coreboot/+/50339/comment/c5c2740a_232fe93b PS1, Line 97: *
nit: remove this `*` to comply with the coding style
This is how clang-format formats it. I changed it to the long style which clang-format also likes.
-
Raul Rangel (Code Review)