Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29243 )
Change subject: {cpu,drivers,nb,sb}/amd: Replace {MSR,MTRR} addresses with macros ......................................................................
Patch Set 9:
(1 comment)
Also, please fix 81+ characters.
https://review.coreboot.org/#/c/29243/9/src/northbridge/amd/amdmct/mct/mctdq... File src/northbridge/amd/amdmct/mct/mctdqs_d.c:
https://review.coreboot.org/#/c/29243/9/src/northbridge/amd/amdmct/mct/mctdq... PS9, Line 822: 0xC0010017 In cpu/amd/mtrr.h replace the declarations (they are wrong): #define IORR_FIRST 0xC0010016 #define IORR_LAST 0xC0010019 with #define IORR0_BASE 0xC0010016 #define IORR0_MASK 0xC0010017 #define IORR1_BASE 0xC0010018 #define IORR1_MASK 0xC0010019
Then fix code where needed. This line will become: _WRMSR(IORR0_MASK, lo, hi); /* IORR0 Mask */