Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Martin L Roth, Matt DeVillier, Patrick Rudolph, Varshit Pandya.
Hello Felix Held, Fred Reitberger, Jason Glenesk, Martin L Roth, Matt DeVillier, Varshit Pandya, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/86618?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins)
Change subject: soc/amd/common: Always use genoa SPI MMAP driver ......................................................................
soc/amd/common: Always use genoa SPI MMAP driver
Currently the generic x86 SPI flash mmap driver is being when not using DMA and when not on GENOA. It only works for ROM_SIZE of 16 MiB or less and prevents boot when the ROM is bigger than that.
Use the genoa_poc SPI MMAP driver on all platforms by default as it allows to use a ROM_SIZE greater than 16MiB. The newly introduced Kconfig SOC_AMD_COMMON_BLOCK_SPI_MMAP is used for all platforms when the SPI DMA driver is not in use.
This doesn't allow to access the whole SPI flash using the ROM2 MMIO window, but it no longer prevents boot when the mainboard specifies the correct SPI flash size in Kconfig.
TEST: Booted an AMD/birman+ with 64MiB ROM specified in Kconfig.
Change-Id: I39e33c71d27179212ddb1f5bcca4c5d4a39d47e4 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/soc/amd/common/block/spi/Kconfig M src/soc/amd/common/block/spi/Makefile.mk R src/soc/amd/common/block/spi/mmap_boot.c M src/soc/amd/genoa_poc/Kconfig M src/soc/amd/genoa_poc/Makefile.mk 5 files changed, 12 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/86618/2