Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44119 )
Change subject: nb/intel/pineview: Remove dead assignments ......................................................................
nb/intel/pineview: Remove dead assignments
The call to `decode_pciebar` always initializes these values.
Change-Id: Ide45e1e5e8b8d6cfebd2fc4e272b1971b0a9b346 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44119 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/northbridge/intel/pineview/acpi.c 1 file changed, 1 insertion(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/northbridge/intel/pineview/acpi.c b/src/northbridge/intel/pineview/acpi.c index 575814c..5becf8d 100644 --- a/src/northbridge/intel/pineview/acpi.c +++ b/src/northbridge/intel/pineview/acpi.c @@ -8,8 +8,7 @@
unsigned long acpi_fill_mcfg(unsigned long current) { - u32 length = 0; - u32 pciexbar = 0; + u32 length, pciexbar; int max_buses;
if (!decode_pciebar(&pciexbar, &length))