Attention is currently required from: Paul Menzel, Arthur Heymans, Patrick Rudolph. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56017 )
Change subject: Documentation: Improve x86_64 ......................................................................
Patch Set 4:
(5 comments)
File Documentation/arch/x86/x86_64.md:
https://review.coreboot.org/c/coreboot/+/56017/comment/8692bc1b_3abcb2f0 PS1, Line 13: * Intel Sandy Bridge boards
Maybe add the `git grep` command to find all boards, or mention the Kconfig symbol?
Added the Kconfig to enable x86_64 support.
https://review.coreboot.org/c/coreboot/+/56017/comment/d7a808f4_59638685 PS1, Line 22: * The BIOS region is large enough to contain the page tables
I don't know the name on AMD hardware. […]
mention that this region exists on intel platforms only.
https://review.coreboot.org/c/coreboot/+/56017/comment/4eb7e13e_a92bbba7 PS1, Line 58: It cannot use 32bit addressing as the memory model
Please add a dot/period at the end of sentences.
Done
https://review.coreboot.org/c/coreboot/+/56017/comment/cb9f3a3d_101b0768 PS1, Line 62: - This requires a complete memory map to be present in postcar stage
Ditto.
Done
File Documentation/arch/x86/x86_64.md:
https://review.coreboot.org/c/coreboot/+/56017/comment/71cb63c1_ee2ac7c3 PS2, Line 10: *hack*
Maybe put it in quotes: “hacks”.
Done
-
Patrick Rudolph (Code Review)