Attention is currently required from: Eran Mitrani, Kapil Porwal, Sumeet R Pawnikar, Tarun, YH Lin.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78260?usp=email )
Change subject: mb/google/rex/var/karis: add hook for WiFi SAR table
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File src/mainboard/google/rex/Kconfig:
https://review.coreboot.org/c/coreboot/+/78260/comment/386410fe_453760ba :
PS4, Line 79: select CHROMEOS_WIFI_SAR if CHR
Do we still need to add this here, if removing in another patch https://review.coreboot.org/c/coreboot/+/78308/1/src/mainboard/google/rex/Kc...
this is better @Sumeet. marking the comment resolved.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78260?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic989024ab9eb0fc439fc701c335a85986c4cfec5
Gerrit-Change-Number: 78260
Gerrit-PatchSet: 4
Gerrit-Owner: YH Lin
yueherngl@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Wed, 11 Oct 2023 09:55:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-MessageType: comment