EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46847 )
Change subject: mb/google/octopus/var/fleex: Add variant into smm stage ......................................................................
mb/google/octopus/var/fleex: Add variant into smm stage
variant_smi_sleep is called in smm stage so we need add variant.c into smm stage. Otherwise it will call the dummy one.
BUG=b:168075958 BRANCH=octopus TEST=build image passed.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I41df1a30b119ab3e04f9ae01955b6044f137527f --- M src/mainboard/google/octopus/variants/fleex/Makefile.inc 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/46847/1
diff --git a/src/mainboard/google/octopus/variants/fleex/Makefile.inc b/src/mainboard/google/octopus/variants/fleex/Makefile.inc index 51c9d39..2835934 100644 --- a/src/mainboard/google/octopus/variants/fleex/Makefile.inc +++ b/src/mainboard/google/octopus/variants/fleex/Makefile.inc @@ -3,3 +3,5 @@ ramstage-y += gpio.c
ramstage-y += variant.c + +smm-y += variant.c
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46847 )
Change subject: mb/google/octopus/var/fleex: Add variant into smm stage ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/46847/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46847/1//COMMIT_MSG@7 PS1, Line 7: variant variant.c
https://review.coreboot.org/c/coreboot/+/46847/1//COMMIT_MSG@9 PS1, Line 9: need add need to add
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Henry Sun, Marco Chen, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46847
to look at the new patch set (#2).
Change subject: mb/google/octopus/var/fleex: Add variant.c into smm stage ......................................................................
mb/google/octopus/var/fleex: Add variant.c into smm stage
variant_smi_sleep is called in smm stage so we need to add variant.c into smm stage. Otherwise it will call the dummy one.
BUG=b:168075958 BRANCH=octopus TEST=build image passed.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I41df1a30b119ab3e04f9ae01955b6044f137527f --- M src/mainboard/google/octopus/variants/fleex/Makefile.inc 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/46847/2
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46847 )
Change subject: mb/google/octopus/var/fleex: Add variant.c into smm stage ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46847/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46847/1//COMMIT_MSG@7 PS1, Line 7: variant
variant. […]
Done
https://review.coreboot.org/c/coreboot/+/46847/1//COMMIT_MSG@9 PS1, Line 9: need add
need to add
Done
Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46847 )
Change subject: mb/google/octopus/var/fleex: Add variant.c into smm stage ......................................................................
Patch Set 2: Code-Review+2
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46847 )
Change subject: mb/google/octopus/var/fleex: Add variant.c into smm stage ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46847 )
Change subject: mb/google/octopus/var/fleex: Add variant.c into smm stage ......................................................................
mb/google/octopus/var/fleex: Add variant.c into smm stage
variant_smi_sleep is called in smm stage so we need to add variant.c into smm stage. Otherwise it will call the dummy one.
BUG=b:168075958 BRANCH=octopus TEST=build image passed.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I41df1a30b119ab3e04f9ae01955b6044f137527f Reviewed-on: https://review.coreboot.org/c/coreboot/+/46847 Reviewed-by: Ivy Jian ivy_jian@compal.corp-partner.google.com Reviewed-by: Marco Chen marcochen@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/octopus/variants/fleex/Makefile.inc 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Marco Chen: Looks good to me, approved Ivy Jian: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/variants/fleex/Makefile.inc b/src/mainboard/google/octopus/variants/fleex/Makefile.inc index 51c9d39..2835934 100644 --- a/src/mainboard/google/octopus/variants/fleex/Makefile.inc +++ b/src/mainboard/google/octopus/variants/fleex/Makefile.inc @@ -3,3 +3,5 @@ ramstage-y += gpio.c
ramstage-y += variant.c + +smm-y += variant.c
-
EricR Lai (Code Review) -
Ivy Jian (Code Review)
-
Marco Chen (Code Review)
-
Patrick Georgi (Code Review)