HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41296 )
Change subject: mb/google/kahlee: Remove direct 'include <soc/gpio.h>' ......................................................................
mb/google/kahlee: Remove direct 'include <soc/gpio.h>'
Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>.
Change-Id: Iaacb71bf08098085315cf66cff8f206163617e48 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/kahlee/bootblock/bootblock.c M src/mainboard/google/kahlee/romstage.c M src/mainboard/google/kahlee/variants/baseboard/gpio.c M src/mainboard/google/kahlee/variants/baseboard/memory.c M src/mainboard/google/kahlee/variants/baseboard/tpm_tis.c 5 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/41296/1
diff --git a/src/mainboard/google/kahlee/bootblock/bootblock.c b/src/mainboard/google/kahlee/bootblock/bootblock.c index 41dd8de..a7b8428 100644 --- a/src/mainboard/google/kahlee/bootblock/bootblock.c +++ b/src/mainboard/google/kahlee/bootblock/bootblock.c @@ -2,7 +2,7 @@
#include <baseboard/variants.h> #include <bootblock_common.h> -#include <soc/gpio.h> +#include <gpio.h> #include <soc/southbridge.h> #include <amdblocks/lpc.h> #include <variant/ec.h> diff --git a/src/mainboard/google/kahlee/romstage.c b/src/mainboard/google/kahlee/romstage.c index 389834c..8830df4 100644 --- a/src/mainboard/google/kahlee/romstage.c +++ b/src/mainboard/google/kahlee/romstage.c @@ -2,7 +2,7 @@
#include <amdblocks/dimm_spd.h> #include <baseboard/variants.h> -#include <soc/gpio.h> +#include <gpio.h> #include <soc/romstage.h>
int mainboard_read_spd(uint8_t spdAddress, char *buf, size_t len) diff --git a/src/mainboard/google/kahlee/variants/baseboard/gpio.c b/src/mainboard/google/kahlee/variants/baseboard/gpio.c index abdcb0d..928a4af 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/gpio.c +++ b/src/mainboard/google/kahlee/variants/baseboard/gpio.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <baseboard/variants.h> -#include <soc/gpio.h> +#include <gpio.h> #include <soc/southbridge.h> #include <boardid.h> #include <variant/gpio.h> diff --git a/src/mainboard/google/kahlee/variants/baseboard/memory.c b/src/mainboard/google/kahlee/variants/baseboard/memory.c index 8664560..d3d81fd 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/memory.c +++ b/src/mainboard/google/kahlee/variants/baseboard/memory.c @@ -2,7 +2,7 @@
#include <baseboard/variants.h> #include <console/console.h> -#include <gpio.h> /* src/include/gpio.h */ +#include <gpio.h> #include <spd_bin.h> #include <variant/gpio.h> #include <amdblocks/dimm_spd.h> diff --git a/src/mainboard/google/kahlee/variants/baseboard/tpm_tis.c b/src/mainboard/google/kahlee/variants/baseboard/tpm_tis.c index 63625c4..3c60cba 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/tpm_tis.c +++ b/src/mainboard/google/kahlee/variants/baseboard/tpm_tis.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <security/tpm/tis.h> -#include <soc/gpio.h> +#include <gpio.h> #include <variant/gpio.h>
int tis_plat_irq_status(void)
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/41296 )
Change subject: mb/google/kahlee: Remove direct 'include <soc/gpio.h>' ......................................................................
Abandoned
see #41324
-
HAOUAS Elyes (Code Review)