Attention is currently required from: Matt DeVillier, Andy Pont, Paul Menzel, Angel Pons. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56088 )
Change subject: mainboard/starlabs: Add StarBook Mk V ......................................................................
Patch Set 77:
(4 comments)
File src/mainboard/starlabs/labtop/Kconfig:
https://review.coreboot.org/c/coreboot/+/56088/comment/ed5982b2_c284a6b2 PS77, Line 4: Mk IV CML Board
copy/pasta error :)
Done
File src/mainboard/starlabs/labtop/cmos.layout:
https://review.coreboot.org/c/coreboot/+/56088/comment/689bc083_1e6caaea PS77, Line 47: outwith the checksummed area
not sure what this is supposed to mean
Me neither!
File src/mainboard/starlabs/labtop/mainboard.c:
https://review.coreboot.org/c/coreboot/+/56088/comment/a53710bf_3074fb1e PS77, Line 94: sixteen
feel like a more descriptive function name would be beneficial here
Done
File src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/56088/comment/0d212a0d_ab81d6c0 PS77, Line 213: # TODO:
still todo?
Done
-
Sean Rhodes (Code Review)