build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25739 )
Change subject: lib: Raw import FIT parser ......................................................................
Patch Set 15:
(13 comments)
https://review.coreboot.org/#/c/25739/15/src/include/fit.h File src/include/fit.h:
https://review.coreboot.org/#/c/25739/15/src/include/fit.h@28 PS15, Line 28: { open brace '{' following enum go on the same line
https://review.coreboot.org/#/c/25739/15/src/include/fit.h@36 PS15, Line 36: { open brace '{' following struct go on the same line
https://review.coreboot.org/#/c/25739/15/src/include/fit.h@46 PS15, Line 46: { open brace '{' following struct go on the same line
https://review.coreboot.org/#/c/25739/15/src/lib/fit.c File src/lib/fit.c:
https://review.coreboot.org/#/c/25739/15/src/lib/fit.c@194 PS15, Line 194: const char *path[] = { "chosen", NULL }; char * array declaration might be better as static const
https://review.coreboot.org/#/c/25739/15/src/lib/fit.c@202 PS15, Line 202: const char *path[] = { "chosen", NULL }; char * array declaration might be better as static const
https://review.coreboot.org/#/c/25739/15/src/lib/fit.c@225 PS15, Line 225: { open brace '{' following struct go on the same line
https://review.coreboot.org/#/c/25739/15/src/lib/fit.c@226 PS15, Line 226: unsigned addr_cells; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/25739/15/src/lib/fit.c@227 PS15, Line 227: unsigned size_cells; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/25739/15/src/lib/fit.c@231 PS15, Line 231: static uint64_t max_range(unsigned size_cells) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/25739/15/src/lib/fit.c@242 PS15, Line 242: unsigned *count = (unsigned *)params->data; Prefer 'unsigned int *' to bare use of 'unsigned *'
https://review.coreboot.org/#/c/25739/15/src/lib/fit.c@242 PS15, Line 242: unsigned *count = (unsigned *)params->data; Prefer 'unsigned int *' to bare use of 'unsigned *'
https://review.coreboot.org/#/c/25739/15/src/lib/fit.c@298 PS15, Line 298: * Kernel likes its availabe memory areas at least 1MB 'availabe' may be misspelled - perhaps 'available'?
https://review.coreboot.org/#/c/25739/15/src/lib/fit.c@323 PS15, Line 323: unsigned count = 0; Prefer 'unsigned int' to bare use of 'unsigned'
-
build bot (Jenkins) (Code Review)