Attention is currently required from: Andrey Petrov, Jérémy Compostella, Patrick Rudolph, Ronak Kanabar.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81281?usp=email )
Change subject: drivers/intel/fsp2_0: Support FSP-T in long mode
......................................................................
Patch Set 2:
(2 comments)
File src/soc/intel/common/block/cpu/car/cache_as_ram_fsp.S:
https://review.coreboot.org/c/coreboot/+/81281/comment/7932391d_3aeb36d7 :
PS2, Line 7: #include <cpu/x86/64bit/entry64.inc>
Alphabetical order ?
Done
https://review.coreboot.org/c/coreboot/+/81281/comment/b48d9b58_90bf4d76 :
PS2, Line 95: CONFIG_ARCH_X86_64_PGTBL_LOC
Make sure it is aligned with https://review.coreboot. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81281?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id6b9780b06b4bfbb952e32091ffbf3d0014f2090
Gerrit-Change-Number: 81281
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Thu, 28 Mar 2024 13:44:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-MessageType: comment