Change in coreboot[master]: soc/amd/common/block/acpimmio: use all-y for mmio_util target
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48436 )
Change subject: soc/amd/common/block/acpimmio: use all-y for mmio_util target ......................................................................
soc/amd/common/block/acpimmio: use all-y for mmio_util target
since mmio_util gets also liked int verstage on PSP, all-y can be used here.
Change-Id: I03572d760b485938f0d00b6cead00746eda6ca09 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/common/block/acpimmio/Makefile.inc 1 file changed, 1 insertion(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/48436/1
diff --git a/src/soc/amd/common/block/acpimmio/Makefile.inc b/src/soc/amd/common/block/acpimmio/Makefile.inc index 6b3e423..c93e67d 100644 --- a/src/soc/amd/common/block/acpimmio/Makefile.inc +++ b/src/soc/amd/common/block/acpimmio/Makefile.inc @@ -1,10 +1,6 @@ ifeq ($(CONFIG_SOC_AMD_COMMON_BLOCK_ACPIMMIO),y)
-bootblock-y += mmio_util.c -verstage-y += mmio_util.c -romstage-y += mmio_util.c -postcar-y += mmio_util.c -ramstage-y += mmio_util.c +all-y += mmio_util.c smm-y += mmio_util.c
bootblock-y += biosram.c
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48436 )
Change subject: soc/amd/common/block/acpimmio: use all-y for mmio_util target ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48436/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48436/1//COMMIT_MSG@9 PS1, Line 9: liked int linked into?
Hello build bot (Jenkins), Jason Glenesk, Patrick Georgi, Martin Roth, Marshall Dawson,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48436
to look at the new patch set (#2).
Change subject: soc/amd/common/block/acpimmio: use all-y for mmio_util target ......................................................................
soc/amd/common/block/acpimmio: use all-y for mmio_util target
Since mmio_util gets also linked into verstage on PSP, all-y can be used here.
Change-Id: I03572d760b485938f0d00b6cead00746eda6ca09 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/common/block/acpimmio/Makefile.inc 1 file changed, 1 insertion(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/48436/2
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48436 )
Change subject: soc/amd/common/block/acpimmio: use all-y for mmio_util target ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48436/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48436/1//COMMIT_MSG@9 PS1, Line 9: liked int
linked into?
Done
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48436 )
Change subject: soc/amd/common/block/acpimmio: use all-y for mmio_util target ......................................................................
Patch Set 2: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48436 )
Change subject: soc/amd/common/block/acpimmio: use all-y for mmio_util target ......................................................................
soc/amd/common/block/acpimmio: use all-y for mmio_util target
Since mmio_util gets also linked into verstage on PSP, all-y can be used here.
Change-Id: I03572d760b485938f0d00b6cead00746eda6ca09 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/48436 Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/common/block/acpimmio/Makefile.inc 1 file changed, 1 insertion(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved
diff --git a/src/soc/amd/common/block/acpimmio/Makefile.inc b/src/soc/amd/common/block/acpimmio/Makefile.inc index 6b3e423..c93e67d 100644 --- a/src/soc/amd/common/block/acpimmio/Makefile.inc +++ b/src/soc/amd/common/block/acpimmio/Makefile.inc @@ -1,10 +1,6 @@ ifeq ($(CONFIG_SOC_AMD_COMMON_BLOCK_ACPIMMIO),y)
-bootblock-y += mmio_util.c -verstage-y += mmio_util.c -romstage-y += mmio_util.c -postcar-y += mmio_util.c -ramstage-y += mmio_util.c +all-y += mmio_util.c smm-y += mmio_util.c
bootblock-y += biosram.c
-
Felix Held (Code Review) -
Marshall Dawson (Code Review)