Attention is currently required from: Cliff Huang, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56006 )
Change subject: soc/intel/alderlake: Switch to runtime generation of Intel Power Engine
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/alderlake/pmc.c:
https://review.coreboot.org/c/coreboot/+/56006/comment/9758fc6e_e57a142e
PS1, Line 126: /* Add Intel Power Engine device */
Please add #if CONFIG(CONFIG_SOC_INTEL_COMMON_BLOCK_ACPI_PEP) here so that we can still build even w […]
`generate_acpi_power_engine` will not be compiled in unless `SOC_INTEL_COMMON_BLOCK_ACPI_PEP` is selected (which this CL already does), which would cause a compile error, I don't understand your concern?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56006
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I617bc3d1c3cf4ac6b6cbbd790dcf62e731024834
Gerrit-Change-Number: 56006
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 07 Jul 2021 15:48:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Cliff Huang
cliff.huang@intel.com
Gerrit-MessageType: comment