Attention is currently required from: Elyes Haouas, Felix Singer, Martin L Roth, Paul Menzel.
Jon Murphy has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/85718?usp=email )
Change subject: util/crossgcc: Update DESTDIR variable use ......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85718/comment/d7b5e2fc_84949d03?usp... : PS2, Line 7: Update variable use
Maybe be more specific: […]
Done
https://review.coreboot.org/c/coreboot/+/85718/comment/a49ec49f_e1e0cc37?usp... : PS2, Line 14: Change-Id: I9eb833b11f20b72db88e4094a3297a1d8891bac2
missing sign-off
Done
File util/crossgcc/buildgcc:
https://review.coreboot.org/c/coreboot/+/85718/comment/4391e57b_c867d280?usp... : PS2, Line 873: "$DESTDIR"
would you please teach me why you did this modification here and not at lines #665, #683, ... […]
I made the change here, but I didn't make the changes on the other lines. It's probably worth making that change in the other places as well, largely this change reflects the coding style guides for ChromeOS. Happy to make the adjustments to the other lines as well, unless the separation was intended by the original author, and that I'm not sure of.