Attention is currently required from: Angel Pons, Benjamin Doron, Julius Werner.
David Milosevic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79106?usp=email )
Change subject: arch/arm64: Extend cache helper functions ......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79106/comment/aaa6642e_671ff7cd : PS4, Line 12: Furthermore, static functions were grouped and moved to the top and : non-static functions to the bottom, in order to provide a better : structure to the file.
Please don't. […]
Done
File src/arch/arm64/armv8/cache.c:
https://review.coreboot.org/c/coreboot/+/79106/comment/edeb9257_93de9ce5 : PS4, Line 14: enum dcache_op { : OP_DCCSW, : OP_DCCISW, : OP_DCISW, : OP_DCCIVAC, : OP_DCCVAC, : OP_DCIVAC, : };
What benefit does moving this enum away from the `dcache_op_va()` function provide?
Done
https://review.coreboot.org/c/coreboot/+/79106/comment/f8610024_613a9205 : PS4, Line 113: enum cache_type cpu_get_cache_type(enum cache_level level) : { : uint32_t ctype_bitshift = (level - 1) * 3; : : if (level < CACHE_L1 || level > CACHE_L7) : return NO_CACHE; : : /* 3-bits per cache-level */ : return (raw_read_clidr_el1() >> ctype_bitshift) & 0x7; : }
Unless you have to, please avoid moving functions around. […]
Done