Attention is currently required from: yu jiaxin. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60738 )
Change subject: mb/google/corsola: Support audio ......................................................................
Patch Set 1:
(12 comments)
File src/mainboard/google/corsola/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137130): https://review.coreboot.org/c/coreboot/+/60738/comment/c7d30201_f414b8c8 PS1, Line 29: /* Power on audio */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137130): https://review.coreboot.org/c/coreboot/+/60738/comment/624448d0_e075de5d PS1, Line 30: mtcmos_audio_power_on(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137130): https://review.coreboot.org/c/coreboot/+/60738/comment/fe606505_2e9f7b99 PS1, Line 30: mtcmos_audio_power_on(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137130): https://review.coreboot.org/c/coreboot/+/60738/comment/e9bc0295_9f233826 PS1, Line 32: /* Set up I2S */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137130): https://review.coreboot.org/c/coreboot/+/60738/comment/e509d592_9902d43b PS1, Line 33: gpio_set_mode(GPIO(I2S2_MCK), PAD_I2S2_MCK_FUNC_I2S2_MCK); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137130): https://review.coreboot.org/c/coreboot/+/60738/comment/52614081_3d9a523f PS1, Line 33: gpio_set_mode(GPIO(I2S2_MCK), PAD_I2S2_MCK_FUNC_I2S2_MCK); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137130): https://review.coreboot.org/c/coreboot/+/60738/comment/c234b108_e87ea1fb PS1, Line 34: gpio_set_mode(GPIO(I2S2_BCK), PAD_I2S2_BCK_FUNC_I2S2_BCK); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137130): https://review.coreboot.org/c/coreboot/+/60738/comment/859d4e99_e12f3b35 PS1, Line 34: gpio_set_mode(GPIO(I2S2_BCK), PAD_I2S2_BCK_FUNC_I2S2_BCK); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137130): https://review.coreboot.org/c/coreboot/+/60738/comment/ba20f4ec_b17bc187 PS1, Line 35: gpio_set_mode(GPIO(I2S2_LRCK), PAD_I2S2_LRCK_FUNC_I2S2_LRCK); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137130): https://review.coreboot.org/c/coreboot/+/60738/comment/fcb74817_9ef40e00 PS1, Line 35: gpio_set_mode(GPIO(I2S2_LRCK), PAD_I2S2_LRCK_FUNC_I2S2_LRCK); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137130): https://review.coreboot.org/c/coreboot/+/60738/comment/5d4a4937_fca78f05 PS1, Line 36: gpio_set_mode(GPIO(EINT4), PAD_EINT4_FUNC_I2S3_DO); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137130): https://review.coreboot.org/c/coreboot/+/60738/comment/1028a060_27f8abdd PS1, Line 36: gpio_set_mode(GPIO(EINT4), PAD_EINT4_FUNC_I2S3_DO); please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)